Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type information from Any #139

Closed
crwilcox opened this issue Aug 4, 2020 · 0 comments · Fixed by #176
Closed

Improve type information from Any #139

crwilcox opened this issue Aug 4, 2020 · 0 comments · Fixed by #176
Assignees
@HemangChothani
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v2

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Aug 4, 2020 •
edited

#134 adds type hints to the manual surface. Though in many cases, the type specified is Any which isn't all that helpful. It would be great if we could remove instances of Any and replace with a concrete type.

if you search for -> Any all of those could possibly improved with more precise type hints.

Work should target v2-staging branch for the time being.
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 4, 2020
@crwilcox crwilcox added this to the v2 milestone Aug 4, 2020
@crwilcox crwilcox added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 4, 2020
@HemangChothani HemangChothani self-assigned this Aug 25, 2020
@HemangChothani HemangChothani mentioned this issue Aug 27, 2020
Merged
@HemangChothani HemangChothani linked a pull request Sep 7, 2020 that will close this issue
feat: improve type information #176
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

feat: improve type information MaxxleLLC/python-firestore
2 participants
@crwilcox @HemangChothani