Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asyncio microgen transaction #123

Merged
merged 21 commits into from Jul 28, 2020
Merged

feat: asyncio microgen transaction #123

merged 21 commits into from Jul 28, 2020

Conversation

rafilong
Copy link
Contributor

Resolves #78

@rafilong rafilong added this to the AsyncIO Client milestone Jul 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
tritone
tritone reviewed Jul 23, 2020
View reviewed changes
Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, one question about testing.

tests/unit/v1/test_async_transaction.py Show resolved Hide resolved
@rafilong rafilong mentioned this pull request Jul 28, 2020
Merged
@rafilong rafilong mentioned this pull request Jul 28, 2020
Closed
@rafilong rafilong merged commit 35185a8 into googleapis:v2-staging Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox left review comments

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
AsyncIO Client
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafilong @crwilcox @BenWhitehead @tritone