Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autospec or manual spec to async unit testing #133

Closed
rafilong opened this issue Jul 28, 2020 · 1 comment
Closed

Add autospec or manual spec to async unit testing #133

rafilong opened this issue Jul 28, 2020 · 1 comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: process A process-related concern. May include testing, release, or the like.
Milestone
AsyncIO Client

Comments

@rafilong
Copy link
Contributor

As we create our own AsyncMock class, extending MagicMock, we cannot use create_autospec to create mocks in async unit tests. We should investigate creating a create_autospec counterpart for async, or alternatively manually spec classes that are tested.

#123 (comment)
@rafilong rafilong added the api: firestore Issues related to the googleapis/python-firestore API. label Jul 28, 2020
@rafilong rafilong added this to the AsyncIO Client milestone Jul 28, 2020
@rafilong rafilong self-assigned this Jul 28, 2020
@rafilong rafilong mentioned this issue Jul 28, 2020
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 29, 2020
@crwilcox crwilcox added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Aug 6, 2020
@meredithslota
Copy link
Contributor

Closing this out as a "Won't Fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
AsyncIO Client
Development

No branches or pull requests
4 participants
@crwilcox @meredithslota @rafilong @yoshi-automation