Skip to content

Commit

Permalink
chore: remove unused 'allow_empty_mask' extractor arg
Browse files Browse the repository at this point in the history
Residue from PR #219.
  • Loading branch information
tseaver committed Oct 22, 2020
1 parent dcaa254 commit 8ed20f0
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions google/cloud/firestore_v1/_helpers.py
Expand Up @@ -757,8 +757,7 @@ def _get_update_mask(
if field_path not in self.transform_merge
]

if mask_paths or allow_empty_mask:
return common.DocumentMask(field_paths=mask_paths)
return common.DocumentMask(field_paths=mask_paths)


def pbs_for_set_with_merge(
Expand All @@ -780,10 +779,8 @@ def pbs_for_set_with_merge(
extractor = DocumentExtractorForMerge(document_data)
extractor.apply_merge(merge)

merge_empty = not document_data
allow_empty_mask = merge_empty or extractor.transform_paths
set_pb = extractor.get_update_pb(document_path)

set_pb = extractor.get_update_pb(document_path, allow_empty_mask=allow_empty_mask)
if extractor.transform_paths:
field_transform_pbs = extractor.get_field_transform_pbs(document_path)
set_pb.update_transforms.extend(field_transform_pbs)
Expand Down

0 comments on commit 8ed20f0

Please sign in to comment.