Skip to content

Commit

Permalink
chore: s.remove_staging_dirs() should only be called once (#362)
Browse files Browse the repository at this point in the history
There is [an issue](https://github.com/googleapis/python-firestore/blob/master/owlbot.py#L60) in the `owlbot.py` file added in #352 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over.  [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.
  • Loading branch information
parthea committed May 25, 2021
1 parent 6e2c899 commit 522ded5
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ def update_fixup_scripts(library):
update_fixup_scripts(library)
s.move(library / "scripts")

s.remove_staging_dirs()

for library in s.get_staging_dirs(admin_default_version):
if library.parent.absolute() == 'admin':
s.move(
Expand All @@ -70,8 +68,6 @@ def update_fixup_scripts(library):
update_fixup_scripts(library)
s.move(library / "scripts")

s.remove_staging_dirs()

for library in s.get_staging_dirs(bundle_default_version):
if library.parent.absolute() == 'bundle':
s.replace(
Expand Down Expand Up @@ -251,4 +247,4 @@ def lint_setup_py(session):
*************
Test Coverage"""
)
)

0 comments on commit 522ded5

Please sign in to comment.