This repository has been archived by the owner on Dec 10, 2023. It is now read-only.
fix!: rename fields that collide with builtins; retrieve job config for risk analysis jobs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Author: Takashi Matsuo <tmatsuo@google.com> Source-Date: Tue Sep 1 17:14:08 2020 +0000 Source-Repo: googleapis/synthtool Source-Sha: d91dd8aac77f7a9c5506c238038a26fa4f9e361e Source-Link: googleapis/synthtool@d91dd8a
* chore(py-library): update decrypt secrets file From https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/scripts/decrypt-secrets.sh * docs: explain conditional Co-authored-by: Jeffrey Rennie <rennie@google.com> Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Tue Sep 8 11:35:59 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: d302f93d7f47e2852e585ac35ab2d15585717ec0 Source-Link: googleapis/synthtool@d302f93
Originally tested at: googleapis/python-texttospeech#89 This change will fix the missing docstring in the yaml files. Source-Author: Takashi Matsuo <tmatsuo@google.com> Source-Date: Thu Sep 10 04:12:14 2020 +0000 Source-Repo: googleapis/synthtool Source-Sha: ffcee7952b74f647cbb3ef021d95422f10816fca Source-Link: googleapis/synthtool@ffcee79
* build(python): use release-publish app for notifying GitHub of release status * fix: re-add pypi password Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 16 08:46:42 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 257fda18168bedb76985024bd198ed1725485488 Source-Link: googleapis/synthtool@257fda1
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 16 10:24:40 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: dba48bb9bc6959c232bec9150ac6313b608fe7bd Source-Link: googleapis/synthtool@dba48bb
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Mon Sep 21 13:09:57 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 27f4406999b1eee29e04b09b2423a8e4646c7e24 Source-Link: googleapis/synthtool@27f4406
`pip install -e .` is supported and is how we install the library for tests. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Tue Sep 22 12:06:12 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: a651c5fb763c69a921aecdd3e1d8dc51dbf20f8d Source-Link: googleapis/synthtool@a651c5f
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32 `BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 30 13:06:03 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4 Source-Link: googleapis/synthtool@9b0da52
Closes #792 Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Fri Oct 9 15:06:33 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: e0ae456852bf22f38796deb79cff30b516fde244 Source-Link: googleapis/synthtool@e0ae456
Source-Author: Daniel Sanche <d.sanche14@gmail.com> Source-Date: Wed Oct 14 08:00:06 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 477764cc4ee6db346d3febef2bb1ea0abf27de52 Source-Link: googleapis/synthtool@477764c
Source-Author: Takashi Matsuo <tmatsuo@google.com> Source-Date: Fri Oct 16 09:58:05 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: da5c6050d13b4950c82666a81d8acd25157664ae Source-Link: googleapis/synthtool@da5c605
Source-Author: Christopher Wilcox <crwilcox@google.com> Source-Date: Thu Oct 22 14:22:01 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76 Source-Link: googleapis/synthtool@5f6ef0e
Source-Author: Tim Swast <swast@google.com> Source-Date: Tue Oct 27 12:01:14 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: ea52b8a0bd560f72f376efcf45197fb7c8869120 Source-Link: googleapis/synthtool@ea52b8a
I recently submitted https://github.com/googleapis/synthtool/pull/811/files, allowing external dependencies for unit tests. This fixes a small missing comma bug Source-Author: Daniel Sanche <d.sanche14@gmail.com> Source-Date: Thu Oct 29 16:58:01 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 6542bd723403513626f61642fc02ddca528409aa Source-Link: googleapis/synthtool@6542bd7
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Source-Date: Wed Nov 4 17:36:32 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: 3d3e94c4e02370f307a9a200b0c743c3d8d19f29 Source-Link: googleapis/synthtool@3d3e94c
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Source-Date: Thu Nov 5 15:22:03 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: 1f1148d3c7a7a52f0c98077f976bd9b3c948ee2b Source-Link: googleapis/synthtool@1f1148d
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Source-Date: Thu Nov 12 11:30:49 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: e89175cf074dccc4babb4eca66ae913696e47a71 Source-Link: googleapis/synthtool@e89175c
product-auto-label
bot
added
the
api: dlp
google-cla
bot
added
the
cla: yes
tmatsuo
changed the title
tmatsuo
changed the title
busunkim96
reviewed
Nov 26, 2020
|
|
||
|
|
||
| class ByteContentItem(proto.Message): | ||
| r"""Container for bytes to inspect or redact. | ||
|
|
||
| Attributes: | ||
| type (~.dlp.ByteContentItem.BytesType): | ||
| type_ (~.dlp.ByteContentItem.BytesType): |
There was a problem hiding this comment.
Rename ByteContentItem.type to ByteContentItem.type_
| @@ -1867,6 +1931,8 @@ class AnalyzeDataSourceRiskDetails(proto.Message): | |||
| K-map result | |||
| delta_presence_estimation_result (~.dlp.AnalyzeDataSourceRiskDetails.DeltaPresenceEstimationResult): | |||
| Delta-presence result | |||
| requested_options (~.dlp.AnalyzeDataSourceRiskDetails.RequestedRiskAnalysisOptions): | |||
| @@ -735,13 +737,13 @@ class MetadataLocation(proto.Message): | |||
| r"""Metadata Location | |||
|
|
|||
| Attributes: | |||
| type (~.dlp.MetadataType): | |||
| type_ (~.dlp.MetadataType): | |||
There was a problem hiding this comment.
MetadataLocation.type -> MetadataLocation.type_
| @@ -814,7 +816,7 @@ class Container(proto.Message): | |||
| record. | |||
|
|
|||
| Attributes: | |||
| type (str): | |||
| type_ (str): | |||
There was a problem hiding this comment.
Container.type -> Container.type_
| @@ -2855,21 +2937,21 @@ class Bucket(proto.Message): | |||
| values. | |||
|
|
|||
| Attributes: | |||
| min (~.dlp.Value): | |||
| min_ (~.dlp.Value): | |||
There was a problem hiding this comment.
Bucket.min -> Bucket.min_
| Lower bound of the range, inclusive. Type | ||
| should be the same as max if used. | ||
| max (~.dlp.Value): | ||
| max_ (~.dlp.Value): |
There was a problem hiding this comment.
Bucket.max -> Bucket.max_
| @@ -4201,7 +4366,7 @@ class DlpJob(proto.Message): | |||
| Attributes: | |||
| name (str): | |||
| The server-assigned name. | |||
| type (~.dlp.DlpJobType): | |||
| type_ (~.dlp.DlpJobType): | |||
There was a problem hiding this comment.
DlpJob.type -> DlpJob.type_
| @@ -4323,7 +4505,7 @@ class ListDlpJobsRequest(proto.Message): | |||
| The standard list page size. | |||
| page_token (str): | |||
| The standard list page token. | |||
| type (~.dlp.DlpJobType): | |||
| type_ (~.dlp.DlpJobType): | |||
There was a problem hiding this comment.
GetDlpJobRequest.type -> GetDlpJobRequest.type_
busunkim96
added
the
do not merge
busunkim96
changed the title
|
Please merge next on/after Wednesday (12/02/2020) to avoid drift between the samples and the latest release on PyPI. |
tmatsuo
approved these changes
Nov 30, 2020
busunkim96
removed
the
do not merge
busunkim96
approved these changes
Dec 2, 2020
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [3.0.0](https://www.github.com/googleapis/python-dlp/compare/v2.0.0...v3.0.0) (2020-12-02) ### ⚠ BREAKING CHANGES * rename fields that collide with builtins (#75) * `ByteContentItem.type` -> `ByteContentItem.type_` * `MetadataLocation.type` -> `MetadataLocation.type_` * `Container.type` -> `Container.type_` * `Bucket.min` -> `Bucket.min_` * `Bucket.max `-> `Bucket.max_` * `DlpJob.type` -> `DlpJob.type_` * `GetDlpJobRequest.type` -> `GetDlpJobRequest.type_` ### Bug Fixes * rename fields that collide with builtins; retrieve job config for risk analysis jobs ([#75](https://www.github.com/googleapis/python-dlp/issues/75)) ([4f3148e](https://www.github.com/googleapis/python-dlp/commit/4f3148e93ec3dfc9395aa38a3afc62498500a055)) ### Documentation * **samples:** fix README to accurately reflect the new repo after the move ([#72](https://www.github.com/googleapis/python-dlp/issues/72)) ([dc56806](https://www.github.com/googleapis/python-dlp/commit/dc56806b47f92227e396969d8a583b881aa41fd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: retrieve job config for risk analysis jobs
fix!: rename fields that collide with builtins.
ByteContentItem.type->ByteContentItem.type_MetadataLocation.type->MetadataLocation.type_Container.type->Container.type_Bucket.min->Bucket.min_Bucket.max->Bucket.max_DlpJob.type->DlpJob.type_GetDlpJobRequest.type->GetDlpJobRequest.type_