Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Pandas 0.24 #8

Merged
merged 10 commits into from Sep 27, 2021
Merged

fix: support Pandas 0.24 #8

merged 10 commits into from Sep 27, 2021

Conversation

jimfulton
Copy link
Contributor

@jimfulton jimfulton commented Sep 26, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3
Fixes #6
Closes #7
🦕

Note that this includes/builds on #7

@jimfulton jimfulton requested a review from a team as a code owner September 26, 2021 16:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Sep 26, 2021
@jimfulton jimfulton changed the title fix-support Pandas 0.24 fix: support Pandas 0.24 Sep 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2021
@jimfulton jimfulton mentioned this pull request Sep 26, 2021
4 tasks
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@google-cla
Copy link

google-cla bot commented Sep 27, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 27, 2021
@tswast
Copy link
Collaborator

tswast commented Sep 27, 2021

@googlebot I consent.

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@tswast tswast merged commit e996883 into main Sep 27, 2021
@tswast tswast deleted the pandas-0_24 branch September 27, 2021 15:21
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 28, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-db-dtypes-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #2 🦕

This builds-on/includes #8, which builds-on/includes #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests failing locally with pandas 1.0.0 tests failing locally with pandas 0.24.2
3 participants