Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: test with pre-release google-cloud-core #89

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: test with pre-release google-cloud-core #89

wants to merge 1 commit into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 23, 2020

This pull request is to check that the changes made in googleapis/python-cloud-core#28 do not break this library.

Unit tests pass locally.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@tswast tswast added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@tswast tswast closed this Sep 23, 2020
@tswast
Copy link
Contributor Author

tswast commented Sep 23, 2020

Closing as all tests passed without modification.

I was curious why this library uses google-cloud-core, even though it uses requests directly for the HTTP client. It appears to mostly be for the type conversion helpers in https://github.com/googleapis/python-cloud-core/blob/master/google/cloud/_helpers.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tswast