Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: further avoid using proto-plus wrapper when unmarshalling entities #190

Merged
merged 7 commits into from Jul 9, 2021
Merged

perf: further avoid using proto-plus wrapper when unmarshalling entities #190

merged 7 commits into from Jul 9, 2021

Commits on Jul 9, 2021

  1. perf: tweak 'helpers._get_meaning'

    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    a755fff View commit details
    Browse the repository at this point in the history

  2. perf: tweak 'helpers._new_value_pb'

    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    018acd9 View commit details
    Browse the repository at this point in the history

  3. perf: inline 'helpers._property_tuples'

    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    3f928e1 View commit details
    Browse the repository at this point in the history

  4. perf: tweak key construction in 'helpers.entity_from_protobuf' 

    This is actually a big win:  in my comparison, we go from 3x to 2x slower
than the older/faster version.
    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    151aa17 View commit details
    Browse the repository at this point in the history

  5. perf: tweak 'helpers._get_value_from_value_pb' 

    Always take the raw protobuf message, rather than the proto-plus wrapper.

This is another big win:  we are back to within a few percent of the
older/faster version on my comparison test.
    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    544d0c1 View commit details
    Browse the repository at this point in the history

  6. tests: suppress expected warning for bad enum value 

    Closes #150.
    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    9910960 View commit details
    Browse the repository at this point in the history

  7. perf: '_get_meaning' is always called w/ raw protobuf message

    @tseaver
    tseaver committed Jul 9, 2021
    Copy the full SHA
    5cbf27a View commit details
    Browse the repository at this point in the history