This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
feat: delete deprecated Dataproc v1beta2 API client #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
kokoro:run
product-auto-label
bot
added
the
api: dataproc
google-cla
bot
added
the
cla: yes
yoshi-kokoro
removed
kokoro:run
parthea
added
kokoro:force-run
|
@leahecole Please could you review/approve? |
yoshi-kokoro
removed
kokoro:run
|
The changes LGTM. Is the intent to take a major bump in this library? |
|
Yes, I'd like to take a major bump. I'll mark this PR as Do Not Merge while I confirm with the broader team. |
parthea
added
the
do not merge
|
I think it's fine by me but also want to cc @loferris - they're working on Dataproc stuff here and there and I want to make sure they see this too |
parthea
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
changed the title
parthea
removed
the
do not merge
busunkim96
approved these changes
Sep 1, 2021
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
added
the
automerge
gcf-merge-on-green
bot
deleted the
owl-bot-f74e8a85-e49b-419e-b9b3-ab196ba40aff
branch
gcf-merge-on-green
bot
removed
the
automerge
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #249. Googlers see internal bug b/197576296.
Committer: @medb
PiperOrigin-RevId: 392723737
Source-Link: googleapis/googleapis@8bf048d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f45e49bb22b39098ca73b18228b2014ab931d38a