Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

v2.6.0 have breaking change without bump major version #271

Closed
mik-laj opened this issue Sep 24, 2021 · 3 comments · Fixed by #273
Closed

v2.6.0 have breaking change without bump major version #271

mik-laj opened this issue Sep 24, 2021 · 3 comments · Fixed by #273
Assignees
@parthea
Labels
api: dataproc Issues related to the googleapis/python-dataproc API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mik-laj
Copy link

mik-laj commented Sep 24, 2021 •
edited

The v2.6.0 have the following changelog entry:

delete deprecated Dataproc v1beta2 API client (#253) (b0db6da)

According to semver:

Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes are introduced to the public API.

Is it possible to mark this release as YANKED and then release a new 3.0 release?
@product-auto-label product-auto-label bot added the api: dataproc Issues related to the googleapis/python-dataproc API. label Sep 24, 2021
@mik-laj mik-laj mentioned this issue Sep 24, 2021
Closed
2 tasks
@potiuk
Copy link

potiuk commented Sep 25, 2021

Yeah. would be super useful to yank it- it brakes our google provider for Apache Airflow (luckily we have constraint mechanism that helps with it but still would be great to get it yanked.

@parthea parthea mentioned this issue Sep 25, 2021
Closed
@parthea
Copy link
Contributor

parthea commented Sep 25, 2021

Hi @mik-laj @potiuk ,

I'm sorry that you encountered this issue. I've yanked the last release google-cloud-dataproc 2.6.0. I've added the do not merge label to the next release PR #272 to avoid the issue from repeating and I'll keep this issue open until the major bump is completed. Please note that the reference documentation for v1beta2 REST API is no longer available on the Google Cloud Dataproc Documentation page. We strongly recommend that you migrate to the stable dataproc_v1 client. Needless to say, the last release included a breaking change and the version should have been bumped to 3.0. I will be more careful with stable releases moving forward.

@parthea parthea mentioned this issue Sep 25, 2021
Merged
@potiuk
Copy link

potiuk commented Sep 25, 2021

I'm sorry that you encountered this issue. I've yanked the last release google-cloud-dataproc 2.6.0. I've added the do not merge label to the next release PR #272 to avoid the issue from repeating and I'll keep this issue open until the major bump is completed. Please note that the reference documentation for v1beta2 REST API is no longer available on the Google Cloud Dataproc Documentation page. We strongly recommend that you migrate to the stable dataproc_v1 client. Needless to say, the last release included a breaking change and the version should have been bumped to 3.0. I will be more careful with stable releases moving forward.

Yeah. Moving the dataproc will happen sooner rather than later I think, but in the meantime having currently released provider work with latest "matching" dataproc is cool :)

@meredithslota meredithslota added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 29, 2021
@parthea
chore: release as 3.0.0 (#273)
3bdeaa7 
Closes #271 

We need to bump the major version as the dataproc v1beta2 client was deleted in #253. The last version that contains the v1beta2 client is version 2.5.0. See #271 for more information.

feat: delete deprecated Dataproc v1beta2 API client
docs: update cluster sample

Release-As: 3.0.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@parthea parthea

Labels
api: dataproc Issues related to the googleapis/python-dataproc API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: release as 3.0.0 googleapis/python-dataproc
4 participants
@potiuk @parthea @meredithslota @mik-laj