Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

docs: convert UPGRADING guide to RST to fix table formatting #268

Merged
merged 8 commits into from Dec 1, 2021
Merged

docs: convert UPGRADING guide to RST to fix table formatting #268

merged 8 commits into from Dec 1, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 18, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #153🦕

@tswast tswast requested a review from a team as a code owner November 18, 2021 16:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2021
@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the googleapis/python-datacatalog API. label Nov 18, 2021
@tswast
Copy link
Contributor Author

tswast commented Nov 18, 2021

Confirmed with local nox -s docs that tables now render correctly:

UPGRADING guide with tables

meredithslota
meredithslota approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@meredithslota meredithslota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tswast
tswast commented Nov 18, 2021
View reviewed changes
docs/index.rst Outdated Show resolved Hide resolved
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2021
@tswast tswast mentioned this pull request Dec 1, 2021
Merged
@tswast tswast mentioned this pull request Dec 1, 2021
Closed
@parthea parthea mentioned this pull request Dec 1, 2021
Closed
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2021
@parthea parthea assigned tswast and unassigned parthea Dec 1, 2021
@tswast
Copy link
Contributor Author

tswast commented Dec 1, 2021

Thanks @parthea !

@tswast tswast merged commit 571171e into main Dec 1, 2021
@tswast tswast deleted the issue153-upgrading-table branch December 1, 2021 21:33
meredithslota added a commit that referenced this pull request Jan 4, 2022
@meredithslota
Revert "docs: convert UPGRADING guide to RST to fix table formatting (#…
01d7361 
…268)"

This reverts commit 571171e.
@meredithslota meredithslota mentioned this pull request Jan 4, 2022
Closed
meredithslota added a commit that referenced this pull request Jan 4, 2022
@meredithslota
docs: reverts the table addition from #114
a1a216a 
Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)
@meredithslota meredithslota mentioned this pull request Jan 4, 2022
Merged
meredithslota added a commit that referenced this pull request Jan 10, 2022
@meredithslota @gcf-owl-bot @parthea
docs: fixing upgrading guide v2 (#277)
76f152a 
* docs: reverts the table addition from #114

Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)

* docs: revert changes to link

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: putting back this section

Owlbot removed this but we need to keep it.

* docs: fix whitespace issue

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* rename docs/UPGRADING.rst to docs/UPGRADING.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meredithslota meredithslota meredithslota approved these changes

Assignees

@tswast tswast

Labels
api: datacatalog Issues related to the googleapis/python-datacatalog API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tswast @meredithslota @parthea