googleapis · busunkim96 · May 10, 2021 · May 9, 2021 · May 9, 2021 · May 9, 2021
diff --git a/.coveragerc b/.coveragerc
@@ -2,7 +2,6 @@
 branch = True
 
 [report]
-fail_under = 100
 show_missing = True
 omit =
     google/cloud/compute/__init__.py

diff --git a/.github/header-checker-lint.yml b/.github/header-checker-lint.yml
@@ -1,6 +1,6 @@
 {"allowedCopyrightHolders": ["Google LLC"],
  "allowedLicenses": ["Apache-2.0", "MIT", "BSD-3"],
- "ignoreFiles": ["**/requirements.txt", "**/requirements-test.txt"],
+ "ignoreFiles": ["**/requirements.txt", "**/requirements-test.txt", "**/__init__.py", "samples/**/constraints.txt", "samples/**/constraints-test.txt"],
  "sourceFileExtensions": [
  	"ts", 
  	"js", 

diff --git a/.kokoro/release.sh b/.kokoro/release.sh
@@ -26,7 +26,7 @@ python3 -m pip install --upgrade twine wheel setuptools
 export PYTHONUNBUFFERED=1
 
 # Move into the package, build the distribution and upload.
-TWINE_PASSWORD=$(cat "${KOKORO_KEYSTORE_DIR}/73713_google_cloud_pypi_password")
+TWINE_PASSWORD=$(cat "${KOKORO_GFILE_DIR}/secret_manager/google-cloud-pypi-token")
 cd github/python-compute
 python3 setup.py sdist bdist_wheel
-twine upload --username gcloudpypi --password "${TWINE_PASSWORD}" dist/*
+twine upload --username __token__ --password "${TWINE_PASSWORD}" dist/*
diff --git a/.kokoro/release/common.cfg b/.kokoro/release/common.cfg
@@ -23,18 +23,8 @@ env_vars: {
     value: "github/python-compute/.kokoro/release.sh"
 }
 
-# Fetch PyPI password	
-before_action {	
-  fetch_keystore {	
-    keystore_resource {	
-      keystore_config_id: 73713	
-      keyname: "google_cloud_pypi_password"	
-    }	
-  }	
-}
-
 # Tokens needed to report release status back to GitHub
 env_vars: {
   key: "SECRET_MANAGER_KEYS"
-  value: "releasetool-publish-reporter-app,releasetool-publish-reporter-googleapis-installation,releasetool-publish-reporter-pem"
-}
+  value: "releasetool-publish-reporter-app,releasetool-publish-reporter-googleapis-installation,releasetool-publish-reporter-pem,google-cloud-pypi-token"
+}
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -26,6 +26,6 @@ repos:
     hooks:
     - id: black
 -   repo: https://gitlab.com/pycqa/flake8
-    rev: 3.9.0
+    rev: 3.9.1
     hooks:
     - id: flake8
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -160,21 +160,7 @@ Running System Tests
   auth settings and change some configuration in your project to
   run all the tests.
 
-- System tests will be run against an actual project and
-  so you'll need to provide some environment variables to facilitate
-  authentication to your project:
-
-  - ``GOOGLE_APPLICATION_CREDENTIALS``: The path to a JSON key file;
-    Such a file can be downloaded directly from the developer's console by clicking
-    "Generate new JSON key". See private key
-    `docs <https://cloud.google.com/storage/docs/authentication#generating-a-private-key>`__
-    for more details.
-
-- Once you have downloaded your json keys, set the environment variable 
-  ``GOOGLE_APPLICATION_CREDENTIALS`` to the absolute path of the json file::
-
-   $ export GOOGLE_APPLICATION_CREDENTIALS="/Users/<your_username>/path/to/app_credentials.json"
-
+- System tests will be run against an actual project. You should use local credentials from gcloud when possible. See `Best practices for application authentication <https://cloud.google.com/docs/authentication/best-practices-applications#local_development_and_testing_with_the>`__. Some tests require a service account. For those tests see `Authenticating as a service account <https://cloud.google.com/docs/authentication/production>`__.
 
 *************
 Test Coverage

diff --git a/docs/_static/custom.css b/docs/_static/custom.css
@@ -1,9 +1,20 @@
 div#python2-eol {
 	border-color: red;
 	border-width: medium;
-} 
+}
 
 /* Ensure minimum width for 'Parameters' / 'Returns' column */
 dl.field-list > dt {
     min-width: 100px
 }
+
+/* Insert space between methods for readability */
+dl.method {
+	padding-top: 10px;
+	padding-bottom: 10px
+}
+
+/* Insert empty space between classes */
+dl.class {
+	padding-bottom: 50px
+}
diff --git a/docs/compute_v1/accelerator_types.rst b/docs/compute_v1/accelerator_types.rst
@@ -5,7 +5,6 @@ AcceleratorTypes
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.accelerator_types.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/addresses.rst b/docs/compute_v1/addresses.rst
@@ -5,7 +5,6 @@ Addresses
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.addresses.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/autoscalers.rst b/docs/compute_v1/autoscalers.rst
@@ -5,7 +5,6 @@ Autoscalers
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.autoscalers.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/backend_buckets.rst b/docs/compute_v1/backend_buckets.rst
@@ -5,7 +5,6 @@ BackendBuckets
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.backend_buckets.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/backend_services.rst b/docs/compute_v1/backend_services.rst
@@ -5,7 +5,6 @@ BackendServices
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.backend_services.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/disk_types.rst b/docs/compute_v1/disk_types.rst
@@ -5,7 +5,6 @@ DiskTypes
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.disk_types.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/disks.rst b/docs/compute_v1/disks.rst
@@ -5,7 +5,6 @@ Disks
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.disks.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/external_vpn_gateways.rst b/docs/compute_v1/external_vpn_gateways.rst
@@ -5,7 +5,6 @@ ExternalVpnGateways
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.external_vpn_gateways.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/firewalls.rst b/docs/compute_v1/firewalls.rst
@@ -5,7 +5,6 @@ Firewalls
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.firewalls.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/forwarding_rules.rst b/docs/compute_v1/forwarding_rules.rst
@@ -5,7 +5,6 @@ ForwardingRules
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.forwarding_rules.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/global_addresses.rst b/docs/compute_v1/global_addresses.rst
@@ -5,7 +5,6 @@ GlobalAddresses
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.global_addresses.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/global_forwarding_rules.rst b/docs/compute_v1/global_forwarding_rules.rst
@@ -5,7 +5,6 @@ GlobalForwardingRules
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.global_forwarding_rules.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/global_network_endpoint_groups.rst b/docs/compute_v1/global_network_endpoint_groups.rst
@@ -5,7 +5,6 @@ GlobalNetworkEndpointGroups
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.global_network_endpoint_groups.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/global_operations.rst b/docs/compute_v1/global_operations.rst
@@ -5,7 +5,6 @@ GlobalOperations
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.global_operations.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/global_organization_operations.rst b/docs/compute_v1/global_organization_operations.rst
@@ -5,7 +5,6 @@ GlobalOrganizationOperations
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.global_organization_operations.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/health_checks.rst b/docs/compute_v1/health_checks.rst
@@ -5,7 +5,6 @@ HealthChecks
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.health_checks.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/images.rst b/docs/compute_v1/images.rst
@@ -5,7 +5,6 @@ Images
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.images.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/instance_group_managers.rst b/docs/compute_v1/instance_group_managers.rst
@@ -5,7 +5,6 @@ InstanceGroupManagers
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.instance_group_managers.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/instance_groups.rst b/docs/compute_v1/instance_groups.rst
@@ -5,7 +5,6 @@ InstanceGroups
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.instance_groups.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/instance_templates.rst b/docs/compute_v1/instance_templates.rst
@@ -5,7 +5,6 @@ InstanceTemplates
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.instance_templates.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/instances.rst b/docs/compute_v1/instances.rst
@@ -5,7 +5,6 @@ Instances
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.instances.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/interconnect_attachments.rst b/docs/compute_v1/interconnect_attachments.rst
@@ -5,7 +5,6 @@ InterconnectAttachments
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.interconnect_attachments.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/interconnect_locations.rst b/docs/compute_v1/interconnect_locations.rst
@@ -5,7 +5,6 @@ InterconnectLocations
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.interconnect_locations.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/interconnects.rst b/docs/compute_v1/interconnects.rst
@@ -5,7 +5,6 @@ Interconnects
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.interconnects.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/licenses.rst b/docs/compute_v1/licenses.rst
@@ -5,7 +5,6 @@ Licenses
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.licenses.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/machine_types.rst b/docs/compute_v1/machine_types.rst
@@ -5,7 +5,6 @@ MachineTypes
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.machine_types.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/network_endpoint_groups.rst b/docs/compute_v1/network_endpoint_groups.rst
@@ -5,7 +5,6 @@ NetworkEndpointGroups
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.network_endpoint_groups.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/networks.rst b/docs/compute_v1/networks.rst
@@ -5,7 +5,6 @@ Networks
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.networks.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/node_groups.rst b/docs/compute_v1/node_groups.rst
@@ -5,7 +5,6 @@ NodeGroups
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.node_groups.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/node_templates.rst b/docs/compute_v1/node_templates.rst
@@ -5,7 +5,6 @@ NodeTemplates
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.node_templates.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/node_types.rst b/docs/compute_v1/node_types.rst
@@ -5,7 +5,6 @@ NodeTypes
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.node_types.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/packet_mirrorings.rst b/docs/compute_v1/packet_mirrorings.rst
@@ -5,7 +5,6 @@ PacketMirrorings
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.packet_mirrorings.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/projects.rst b/docs/compute_v1/projects.rst
@@ -5,7 +5,6 @@ Projects
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.projects.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/region_autoscalers.rst b/docs/compute_v1/region_autoscalers.rst
@@ -5,7 +5,6 @@ RegionAutoscalers
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.region_autoscalers.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/region_backend_services.rst b/docs/compute_v1/region_backend_services.rst
@@ -5,7 +5,6 @@ RegionBackendServices
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.region_backend_services.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/region_commitments.rst b/docs/compute_v1/region_commitments.rst
@@ -5,7 +5,6 @@ RegionCommitments
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.region_commitments.pagers
     :members:
     :inherited-members:
diff --git a/docs/compute_v1/region_disk_types.rst b/docs/compute_v1/region_disk_types.rst
@@ -5,7 +5,6 @@ RegionDiskTypes
     :members:
     :inherited-members:
 
-
 .. automodule:: google.cloud.compute_v1.services.region_disk_types.pagers
     :members:
     :inherited-members: