Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Cannot resize to 0 instances #12

Closed
igor-solomatov opened this issue Feb 2, 2021 · 5 comments · Fixed by #92
Closed

Cannot resize to 0 instances #12

igor-solomatov opened this issue Feb 2, 2021 · 5 comments · Fixed by #92
Assignees
@vam-google
Labels
api: compute Issues related to the googleapis/python-compute API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@igor-solomatov
Copy link

igor-solomatov commented Feb 2, 2021 •
edited

Hi All,

If target size of the region instance group is 0, resize fails with bad request, since ?size=0 parameter is removed

The following check should be if v is not None currently it is if v and 0 equals to False in Python.

python-compute/google/cloud/compute_v1/services/region_instance_group_managers/transports/rest.py

Line 1339 in 16e7294

"{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v

@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Feb 2, 2021
igor-solomatov added a commit to igor-solomatov/python-compute that referenced this issue Feb 2, 2021
@igor-solomatov
googleapis#12: fix incorrectly checked value of request parameters
9ca3c2e
@igor-solomatov igor-solomatov mentioned this issue Feb 2, 2021
Closed
4 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 3, 2021
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Feb 3, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 5, 2021
@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

@yon-mg PTAL

@vchudnov-g vchudnov-g assigned vam-google and unassigned yon-mg Jul 14, 2021
@vchudnov-g
Copy link
Contributor

A fix for this is forthcoming

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 2, 2021
@busunkim96
Copy link
Contributor

@vchudnov-g Has this been addressed? (Just checking as the issue is now OOSLO)

@busunkim96
Copy link
Contributor

Update: @vam-google confirmed a fix has landed in the generator. I am working on re-generating the library right now.

@busunkim96 busunkim96 mentioned this issue Aug 6, 2021
Merged
busunkim96 pushed a commit that referenced this issue Aug 9, 2021
@yoshi-automation
fix!: uint64/int64 fields accept ints instead of strings (#92)
4d673cf 
feat: add always_use_jwt_access
fix: fix required query params handling (closes #12)
fix!: uint64/int64 fields accept ints instead of strings

Release-As: 0.5.0
@busunkim96
Copy link
Contributor

This should be fixed in the latest release google-cloud-compute==0.5.0.

@release-please release-please bot mentioned this issue Jan 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vam-google vam-google

Labels
api: compute Issues related to the googleapis/python-compute API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
7 participants
@parthea @vchudnov-g @busunkim96 @vam-google @yoshi-automation @igor-solomatov @yon-mg