Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Commit

Permalink
fix: remove client recv msg limit
Browse files Browse the repository at this point in the history 
PiperOrigin-RevId: 347055288

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Dec 11 12:44:37 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: dd372aa22ded7a8ba6f0e03a80e06358a3fa0907
Source-Link: googleapis/googleapis@dd372aa
  • Loading branch information
@yoshi-automation
yoshi-automation committed Dec 28, 2020
1 parent 634875d commit a1727c3
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 14 deletions.
1 change: 0 additions & 1 deletion google/cloud/devtools/cloudbuild_v1/services/cloud_build/transports/__init__.py
View file
Expand Up @@ -28,7 +28,6 @@
_transport_registry["grpc"] = CloudBuildGrpcTransport
_transport_registry["grpc_asyncio"] = CloudBuildGrpcAsyncIOTransport


__all__ = (
"CloudBuildTransport",
"CloudBuildGrpcTransport",
Expand Down
19 changes: 13 additions & 6 deletions google/cloud/devtools/cloudbuild_v1/services/cloud_build/transports/grpc.py
View file
Expand Up @@ -156,6 +156,10 @@ def __init__(
ssl_credentials=ssl_credentials,
scopes=scopes or self.AUTH_SCOPES,
quota_project_id=quota_project_id,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
self._ssl_channel_credentials = ssl_credentials
else:
Expand All @@ -174,9 +178,14 @@ def __init__(
ssl_credentials=ssl_channel_credentials,
scopes=scopes or self.AUTH_SCOPES,
quota_project_id=quota_project_id,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)

self._stubs = {} # type: Dict[str, Callable]
self._operations_client = None

# Run the base constructor.
super().__init__(
Expand All @@ -200,7 +209,7 @@ def create_channel(
) -> grpc.Channel:
"""Create and return a gRPC channel object.
Args:
address (Optionsl[str]): The host for the channel to use.
address (Optional[str]): The host for the channel to use.
credentials (Optional[~.Credentials]): The
authorization credentials to attach to requests. These
credentials identify this application to the service. If
Expand Down Expand Up @@ -247,13 +256,11 @@ def operations_client(self) -> operations_v1.OperationsClient:
client.
"""
# Sanity check: Only create a new client if we do not already have one.
if "operations_client" not in self.__dict__:
self.__dict__["operations_client"] = operations_v1.OperationsClient(
self.grpc_channel
)
if self._operations_client is None:
self._operations_client = operations_v1.OperationsClient(self.grpc_channel)

# Return the client from cache.
return self.__dict__["operations_client"]
return self._operations_client

@property
def create_build(
Expand Down
15 changes: 12 additions & 3 deletions google/cloud/devtools/cloudbuild_v1/services/cloud_build/transports/grpc_asyncio.py
View file
Expand Up @@ -201,6 +201,10 @@ def __init__(
ssl_credentials=ssl_credentials,
scopes=scopes or self.AUTH_SCOPES,
quota_project_id=quota_project_id,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
self._ssl_channel_credentials = ssl_credentials
else:
Expand All @@ -219,6 +223,10 @@ def __init__(
ssl_credentials=ssl_channel_credentials,
scopes=scopes or self.AUTH_SCOPES,
quota_project_id=quota_project_id,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)

# Run the base constructor.
Expand All @@ -232,6 +240,7 @@ def __init__(
)

self._stubs = {}
self._operations_client = None

@property
def grpc_channel(self) -> aio.Channel:
Expand All @@ -251,13 +260,13 @@ def operations_client(self) -> operations_v1.OperationsAsyncClient:
client.
"""
# Sanity check: Only create a new client if we do not already have one.
if "operations_client" not in self.__dict__:
self.__dict__["operations_client"] = operations_v1.OperationsAsyncClient(
if self._operations_client is None:
self._operations_client = operations_v1.OperationsAsyncClient(
self.grpc_channel
)

# Return the client from cache.
return self.__dict__["operations_client"]
return self._operations_client

@property
def create_build(
Expand Down
1 change: 0 additions & 1 deletion google/cloud/devtools/cloudbuild_v1/types/__init__.py
View file
Expand Up @@ -61,7 +61,6 @@
ListWorkerPoolsResponse,
)


__all__ = (
"RetryBuildRequest",
"RunBuildTriggerRequest",
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
View file
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/python-cloudbuild.git",
"sha": "b714dfe9f8c21739c7031fc3a642ca8d57f120d7"
"sha": "634875d8ade72a93c08f43d6c093539c61349927"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "1f22d1e9654a2588aa32f3802156d965d8d1f10f",
"internalRef": "340738401"
"sha": "dd372aa22ded7a8ba6f0e03a80e06358a3fa0907",
"internalRef": "347055288"
}
},
{
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/gapic/cloudbuild_v1/test_cloud_build.py
View file
Expand Up @@ -3377,6 +3377,10 @@ def test_cloud_build_transport_channel_mtls_with_client_cert_source(transport_cl
scopes=("https://www.googleapis.com/auth/cloud-platform",),
ssl_credentials=mock_ssl_cred,
quota_project_id=None,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
assert transport.grpc_channel == mock_grpc_channel
assert transport._ssl_channel_credentials == mock_ssl_cred
Expand Down Expand Up @@ -3415,6 +3419,10 @@ def test_cloud_build_transport_channel_mtls_with_adc(transport_class):
scopes=("https://www.googleapis.com/auth/cloud-platform",),
ssl_credentials=mock_ssl_cred,
quota_project_id=None,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
assert transport.grpc_channel == mock_grpc_channel

Expand Down

0 comments on commit a1727c3

Please sign in to comment.