Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Documentation examples out of date #43

Closed
kimskimchi opened this issue Jul 31, 2020 · 1 comment · Fixed by #46
Closed

Documentation examples out of date #43

kimskimchi opened this issue Jul 31, 2020 · 1 comment · Fixed by #46
Assignees
@yoshi-automation
Labels
api: cloudbilling Issues related to the googleapis/python-billingbudgets API. type: docs Improvement to the documentation for an API.

Comments

@kimskimchi
Copy link
Contributor

kimskimchi commented Jul 31, 2020 •
edited

  1. Links broken
    On the main page, the link to "Client Library Documentation" is broken.

  2. Package name update
    In client documentatin, update examples to the correct import.

For example:
Old: from google.cloud import billing_budgets_v1beta1
New: from google.cloud.billing import budgets_v1beta1
@product-auto-label product-auto-label bot added the api: cloudbilling Issues related to the googleapis/python-billingbudgets API. label Jul 31, 2020
This was referenced Jul 31, 2020
Closed
Closed
Merged
@kimskimchi
Copy link
Contributor Author

Seems that 2 will need a v1.0.0 client documentation release, as the current documentation is for 0.4.0

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 1, 2020
@busunkim96 busunkim96 added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Aug 3, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 3, 2020
@kimskimchi
docs: fix link in README (#46)
e77864c 
docs: update Client Documentation link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-billingbudgets/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #43  🦕
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 3, 2020
@release-please
chore: release 1.0.1 (#47)
e26fc15 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.0.1](https://www.github.com/googleapis/python-billingbudgets/compare/v1.0.0...v1.0.1) (2020-08-03)


### Documentation

* fix link in README ([#46](https://www.github.com/googleapis/python-billingbudgets/issues/46)) ([e77864c](https://www.github.com/googleapis/python-billingbudgets/commit/e77864cbe04496488bc2f92580ab31601e75919c)), closes [#43](https://www.github.com/googleapis/python-billingbudgets/issues/43)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yoshi-automation yoshi-automation

Labels
api: cloudbilling Issues related to the googleapis/python-billingbudgets API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
3 participants
@busunkim96 @kimskimchi @yoshi-automation