Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Commit

Permalink
test: add 3.9 unit tests (#59)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshi-automation committed Nov 17, 2020
1 parent 4c62f9c commit 409385c
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 19 deletions.
18 changes: 11 additions & 7 deletions google/cloud/billing/budgets_v1beta1/proto/budget_model.proto
Expand Up @@ -187,13 +187,17 @@ message Filter {
// Only zero or one project can be specified currently.
repeated string projects = 1 [(google.api.field_behavior) = OPTIONAL];

// Optional. A list of credit types to be subtracted from gross cost to
// determine the spend for threshold calculations if and only if
// credit_types_treatment is INCLUDE_SPECIFIED_CREDITS. If
// credit_types_treatment is not INCLUDE_SPECIFIED_CREDITS, this field must be
// empty. See credits.type at
// https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#data-schema
// for a list of acceptable credit type values in this field.
// Optional. If
// [Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
// is INCLUDE_SPECIFIED_CREDITS, this is a list of credit types to be
// subtracted from gross cost to determine the spend for threshold
// calculations.
//
// If
// [Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
// is **not** INCLUDE_SPECIFIED_CREDITS, this field must be empty. See [a list
// of acceptable credit type
// values](https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#credits-type).
repeated string credit_types = 7 [(google.api.field_behavior) = OPTIONAL];

// Optional. If not set, default behavior is `INCLUDE_ALL_CREDITS`.
Expand Down
19 changes: 11 additions & 8 deletions google/cloud/billing/budgets_v1beta1/types/budget_model.py
Expand Up @@ -217,14 +217,17 @@ class Filter(proto.Message):
account, regardless of which project the usage occurred on.
Only zero or one project can be specified currently.
credit_types (Sequence[str]):
Optional. A list of credit types to be subtracted from gross
cost to determine the spend for threshold calculations if
and only if credit_types_treatment is
INCLUDE_SPECIFIED_CREDITS. If credit_types_treatment is not
INCLUDE_SPECIFIED_CREDITS, this field must be empty. See
credits.type at
https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#data-schema
for a list of acceptable credit type values in this field.
Optional. If
[Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
is INCLUDE_SPECIFIED_CREDITS, this is a list of credit types
to be subtracted from gross cost to determine the spend for
threshold calculations.
If
[Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
is **not** INCLUDE_SPECIFIED_CREDITS, this field must be
empty. See `a list of acceptable credit type
values <https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#credits-type>`__.
credit_types_treatment (~.budget_model.Filter.CreditTypesTreatment):
Optional. If not set, default behavior is
``INCLUDE_ALL_CREDITS``.
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Expand Up @@ -28,7 +28,7 @@

DEFAULT_PYTHON_VERSION = "3.8"
SYSTEM_TEST_PYTHON_VERSIONS = ["3.8"]
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8"]
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8", "3.9"]


@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/python-billingbudgets.git",
"sha": "b6db1db2055d122614647e492cd3dcd444ebb7e7"
"sha": "4c62f9c89128f70f84ef886345feeb7cb45b4888"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "5359df5297982d551ac5dcc20c8a29de04c70090",
"internalRef": "341146950"
"sha": "6c0f55f33f882cf97fd3135e93b144ad9c94ebab",
"internalRef": "341478628"
}
},
{
Expand Down

0 comments on commit 409385c

Please sign in to comment.