Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use insecure grpc channel with emulator #946

Merged
merged 6 commits into from Apr 11, 2024

Conversation

daniel-sanche
Copy link
Contributor

Uses insecure channels for the emulator for the sync client, as there are problems with secure channels on some platforms/environments.

This change was also made in firestore: googleapis/python-firestore#402

Fixes #755

@daniel-sanche daniel-sanche requested review from a team as code owners March 19, 2024 23:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 19, 2024
@@ -215,58 +214,21 @@ def _get_scopes(self):
return scopes

def _emulator_channel(self, transport, options):
"""Create a channel using self._credentials
"""Create a channelfor use with the Bigtable emulator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in channelfor

@daniel-sanche daniel-sanche merged commit aa31706 into googleapis:main Apr 11, 2024
27 of 29 checks passed
@daniel-sanche daniel-sanche deleted the insecure_emulator branch April 11, 2024 18:58
@mattthym
Copy link

@daniel-sanche Thank you so much for this! 💐
This makes running tests against the bigtable-emulator in CI/CD pipelines so much easier 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support connecting to bigtable emulator running on separate container/machine
4 participants