New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] chore: benchmark tests #840
Draft
daniel-sanche
wants to merge
15
commits into
googleapis:experimental_v3
Choose a base branch
from
daniel-sanche:test_proxy_benchmarks2
base: experimental_v3
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] chore: benchmark tests #840
daniel-sanche
wants to merge
15
commits into
googleapis:experimental_v3
from
daniel-sanche:test_proxy_benchmarks2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
Pull request size is extra large.
api: bigtable
Issues related to the googleapis/python-bigtable API.
labels
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/python-bigtable API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, blocked on test proxy: #836
This PR adds simple benchmark tests. The main goal currently is for performance profiling, to detect bottlenecks during development. In the future, we can extend this system to get more objective performance metrics, and to
run cross-language benchmarks, to test functionality against existing clients.
Implementation
Benchmarks are implemented in
tests/benchmarks/benchmarks.py
, which define client and server logic to test as part of the benchmark.tests/benchmarks/test_benchmarks.py
is a pytest file that will drive the benchmarks on both the v3 client and the v3 client, and report timing results.Running
python -m pytest test_benchmarks.py --profile
will include a profile trace for each failed benchmark, which can be read through the CLI or visualized in snakeviz to find bottlenecks in the code. We can use this to optimize our code.