feat: Copy Backup #680
Open
feat: Copy Backup #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow copying a Backup.
product-auto-label
bot
added
size: m
Mariatta
force-pushed
the
feat-copy-backup
branch
from
d5f872f
to
f8c9433
Compare
product-auto-label
bot
added
size: l
kolea2
requested changes
Sep 30, 2022
|
|
||
| return api.copy_backup( | ||
| request={ | ||
| "parent": parent, |
There was a problem hiding this comment.
how does this work if the source backup project and parent backup project are different?
There was a problem hiding this comment.
parent is constructed using project_id, instance_id, cluster_id. It's allowed to be different I believe as long as the user have access to both. I'm not seeing any restriction about it from the design doc. From the client we will pass the path, and relay back error from the server.
tests/system/test_table_admin.py
Outdated
| @@ -323,6 +324,27 @@ def test_table_backup( | |||
| temp_table_backup.expire_time | |||
| ) | |||
|
|
|||
| # Testing `backup.copy()` method | |||
| backup_op = temp_backup.copy("copied-backup") | |||
There was a problem hiding this comment.
I would also add some test cases with some of the other parameters set.
There was a problem hiding this comment.
I've added tests that pass additional parameters.
kolea2
reviewed
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.