Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update links to reflect new Github org #48

Merged
merged 7 commits into from Aug 3, 2020
Merged

docs: update links to reflect new Github org #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56dae56
docs(bigtable): replace bad links to the new links
HemangChothani Jun 2, 2020
1b4d722
docs(bigtable): docs(bigtable): replace java links to python links
HemangChothani Jun 9, 2020
0dd5fd3
Merge branch 'master' of https://github.com/googleapis/python-bigtabl…
HemangChothani Jun 9, 2020
def77de
Merge branch 'master' of https://github.com/googleapis/python-bigtabl…
HemangChothani Jun 17, 2020
1b9eed8
Merge branch 'master' of https://github.com/googleapis/python-bigtabl…
HemangChothani Jul 6, 2020
d1d5fbb
Merge branch 'master' of https://github.com/googleapis/python-bigtabl…
HemangChothani Jul 27, 2020
141fad5
Merge branch 'master' into bigtable_issue_41
tseaver Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/client-intro.rst
View file
Open in desktop
Expand Up @@ -86,5 +86,5 @@ one before you can interact with tables or data.

Head next to learn about the :doc:`instance-api`.

.. _Instance Admin: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/tree/master/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1
.. _Table Admin: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/tree/master/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1
.. _Instance Admin: https://github.com/googleapis/java-bigtable/tree/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these link to code in python-bigtable? For example, https://github.com/googleapis/python-bigtable/blob/master/google/cloud/bigtable_admin_v2/proto/bigtable_table_admin.proto?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolea2 Yes, I have also doubt about the links but when i have checked links which is in data-api.rst file they have redirected to the java-hbase and the older link, also i have found related of google-jcloud-ava. If you are sure about those links then i will change all the links which redirect to the python relatable content.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Should be pointing to protos in the python library.

.. _Table Admin: https://github.com/googleapis/java-bigtable/tree/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2
10 changes: 5 additions & 5 deletions docs/data-api.rst
View file
Open in desktop
Expand Up @@ -337,8 +337,8 @@ Just as with reading, the stream can be canceled:

keys_iterator.cancel()

.. _ReadRows: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_service.proto#L36-L38
.. _SampleRowKeys: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_service.proto#L44-L46
.. _MutateRow: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_service.proto#L50-L52
.. _CheckAndMutateRow: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_service.proto#L62-L64
.. _ReadModifyWriteRow: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_service.proto#L70-L72
.. _ReadRows: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto#L54-L61
.. _SampleRowKeys: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto#L67-L73
.. _MutateRow: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto#L77-L84
.. _CheckAndMutateRow: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto#L99-L106
.. _ReadModifyWriteRow: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto#L113-L121
14 changes: 7 additions & 7 deletions docs/instance-api.rst
View file
Open in desktop
Expand Up @@ -126,10 +126,10 @@ Now we go down the hierarchy from
Head next to learn about the :doc:`table-api`.

.. _Instance Admin API: https://cloud.google.com/bigtable/docs/creating-instance
.. _CreateInstance: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1/bigtable_instance_service.proto#L66-L68
.. _GetInstance: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1/bigtable_instance_service.proto#L38-L40
.. _UpdateInstance: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1/bigtable_instance_service.proto#L93-L95
.. _DeleteInstance: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1/bigtable_instance_service.proto#L109-L111
.. _ListInstances: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/instance/v1/bigtable_instance_service.proto#L44-L46
.. _GetOperation: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/longrunning/operations.proto#L43-L45
.. _long-running operation: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/longrunning/operations.proto#L73-L102
.. _CreateInstance: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_instance_admin.proto#L54-L64
.. _GetInstance: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_instance_admin.proto#L67-L72
.. _UpdateInstance: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_instance_admin.proto#L85-L90
.. _DeleteInstance: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_instance_admin.proto#L107-L112
.. _ListInstances: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_instance_admin.proto#L75-L80
.. _GetOperation: https://github.com/googleapis/googleapis/blob/master/google/longrunning/operations.proto#L77-L82
.. _long-running operation: https://github.com/googleapis/googleapis/blob/master/google/longrunning/operations.proto#L128-L162
2 changes: 1 addition & 1 deletion docs/row-filters.rst
View file
Open in desktop
Expand Up @@ -64,4 +64,4 @@ level. For example:
:members:
:show-inheritance:

.. _RowFilter definition: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/1ff247c2e3b7cd0a2dd49071b2d95beaf6563092/bigtable-protos/src/main/proto/google/bigtable/v1/bigtable_data.proto#L195
.. _RowFilter definition: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/data.proto#L214
15 changes: 7 additions & 8 deletions docs/table-api.rst
View file
Open in desktop
Expand Up @@ -143,12 +143,11 @@ data directly via a :class:`Table <google.cloud.bigtable.table.Table>`.

Head next to learn about the :doc:`data-api`.

.. _ListTables: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L40-L42
.. _CreateTable: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L35-L37
.. _DeleteTable: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L50-L52
.. _RenameTable: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L56-L58
.. _GetTable: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L45-L47
.. _CreateColumnFamily: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L61-L63
.. _UpdateColumnFamily: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L66-L68
.. _DeleteColumnFamily: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/2aae624081f652427052fb652d3ae43d8ac5bf5a/bigtable-protos/src/main/proto/google/bigtable/admin/table/v1/bigtable_table_service.proto#L71-L73
.. _ListTables: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L88-L93
.. _CreateTable: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L58-L64
.. _DeleteTable: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L104-L109
.. _GetTable: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L96-L101
.. _CreateColumnFamily: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L115-L121
.. _UpdateColumnFamily: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L115-L121
.. _DeleteColumnFamily: https://github.com/googleapis/java-bigtable/blob/master/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L115-L121
.. _column families: https://cloud.google.com/bigtable/docs/schema-design#column_families_and_column_qualifiers
6 changes: 2 additions & 4 deletions tests/unit/test_row_data.py
View file
Open in desktop
Expand Up @@ -1261,10 +1261,8 @@ def _parse_readrows_acceptance_tests(filename):
"""Parse acceptance tests from JSON

See
https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/\
4d3185662ca61bc9fa1bdf1ec0166f6e5ecf86c6/bigtable-client-core/src/\
test/resources/com/google/cloud/bigtable/grpc/scanner/v2/
read-rows-acceptance-test.json
https://github.com/googleapis/java-conformance-tests/blob/master/src/\
main/resources/com/google/cloud/conformance/bigtable/v2/readrows.json
"""
import json

Expand Down