tests: harden instance admin samples against timeouts #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: bigtable
crwilcox
reviewed
Oct 19, 2021
| # Get the instance created | ||
| instanceadmin.run_instance_operations(PROJECT, INSTANCE, CLUSTER1) | ||
| capsys.readouterr() # throw away output | ||
| # This won't work, because the instance isn't created yet |
There was a problem hiding this comment.
This comment took a bit to understand. Are you saying we can't add a cluster because INSTANCE doesn't exist (and you ensured that in the line above)?
"get the instance created" also feels weird. Are we getting the instance or creating it? I had similar feelings about those above. I recognize those were carried forward.
There was a problem hiding this comment.
The instance creation gets moved down to line 138 here -- the instance does not exist at the point that we first call instanceadmin.add_cluster.
The diff display is weird -- I don't get why it breaks up. All this PR does is move the "ensure the instance is set up" code inside a nested function (and therefore indented), wrapped in a backoff.
tseaver
force-pushed
the
383-434-harden-instanceadmin-samples-vs-timeouts
branch
from
2952d25
to
1acba53
Compare
dandhlee
approved these changes
Oct 20, 2021
kolea2
added
the
kokoro:force-run
kolea2
approved these changes
Oct 20, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383.
Closes #434.