Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use templated noxfile.py #325

Closed
wants to merge 4 commits into from
Closed

chore: use templated noxfile.py #325

wants to merge 4 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 16, 2021 •
edited

Please review PR #326 before this one.

Fixes #324 馃

@parthea parthea requested review from a team as code owners June 16, 2021 11:22
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
busunkim96
busunkim96 reviewed Jun 16, 2021
View reviewed changes
owlbot.py Show resolved Hide resolved
owlbot.py Outdated Show resolved Hide resolved
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@parthea
Copy link
Contributor Author

parthea commented Jun 18, 2021

This is ready for review

@tseaver
Copy link
Contributor

tseaver commented Jun 21, 2021

@parthea, @kolea2 the failing samples look flaky to me: adding a cluster to a new instance is inherently tricksy, and needs more retry magyk fairy dust sprinkled on.

@tseaver
Copy link
Contributor

tseaver commented Jun 25, 2021

Superseded by #344.

@tseaver tseaver closed this Jun 25, 2021
@tseaver tseaver deleted the use-templated-noxfile branch June 25, 2021 21:03
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
26ef7cf 
Extracted from PR #325.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
383497d 
Extracted from PR #325.

Closes #324.
@tseaver tseaver mentioned this pull request Jul 9, 2021
Merged
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
738c722 
Extracted from PR #325.

Closes #324.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
4bdff1b 
Extracted from PR #325.

Closes #324.
tseaver added a commit that referenced this pull request Jul 9, 2021
@tseaver
chore: use templated 'noxfile.py'
398fd27 
Extracted from PR #325.

Closes #324.
tseaver added a commit that referenced this pull request Jul 12, 2021
@tseaver
chore: use templated 'noxfile.py' (#355)
2ee65b7 
Extracted from PR #325.

Closes #324.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 left review comments

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noxfile is not updated with Sphinx version pin
4 participants
@parthea @tseaver @busunkim96 @yoshi-kokoro