New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address issue in establishing an emulator connection #246
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
22a684d
fix: address issue in establishing an emulator connection
crwilcox 9eea814
chore: remove commented out lines
crwilcox ed19cc2
test: update tests
crwilcox f7fe18a
test: add test run for emulated testing
crwilcox ced9620
test: simplify emulator wrapping, ensure env var is passed
crwilcox a05f2d3
test(temporary?): use normal cred flow, not emulatorCreds
crwilcox 7e4bb8e
test: install beta gcloud component
crwilcox 34eee81
test: install bigtable gcloud component
crwilcox 4133c06
test: skip backups on emulator
crwilcox 3e4c72c
test: skip backups on emulator
crwilcox b1f8c6c
chore: linter
crwilcox ea6042e
chore: linter
crwilcox 057e329
chore: cleanup
crwilcox File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,8 +115,12 @@ def setUpModule(): | |
Config.IN_EMULATOR = os.getenv(BIGTABLE_EMULATOR) is not None | ||
|
||
if Config.IN_EMULATOR: | ||
credentials = EmulatorCreds() | ||
Config.CLIENT = Client(admin=True, credentials=credentials) | ||
# I expect users won't always pass creds, just use the usual cred flow | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be removed I think. I am not really familiar with why we were doing this, but perhaps it is worth digging into? (this code is 4+ years old) |
||
# on creation. | ||
# credentials = EmulatorCreds() | ||
# Config.CLIENT = Client(admin=True, credentials=credentials) | ||
Config.CLIENT = Client(admin=True) | ||
|
||
else: | ||
Config.CLIENT = Client(admin=True) | ||
|
||
|
@@ -840,6 +844,7 @@ def test_delete_column_family(self): | |
self.assertEqual(temp_table.list_column_families(), {}) | ||
|
||
def test_backup(self): | ||
self._maybe_emulator_skip("backups are not supported in the emulator") | ||
from google.cloud._helpers import _datetime_to_pb_timestamp | ||
|
||
temp_table_id = "test-backup-table" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change moves most of this to a method. Also, using the method derived in firestore, a secure channel can be used.