New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: test with pre-release google-cloud-core #145

Closed

tswast wants to merge 1 commit into googleapis:master from tswast:google-cloud-core-1.4.2rc1

Contributor

tswast commented Sep 23, 2020

This pull request is to check that the changes made in googleapis/python-cloud-core#28 do not break this library.


          DO NOT MERGE: test with pre-release google-cloud-core

d16358d

tswast requested a review from a team as a code owner

September 23, 2020 15:10

google-cla bot added the cla: yes label

tswast closed this

Contributor Author

tswast commented Sep 23, 2020

Closing as all tests passed without modification.

I was curious why google-cloud-bigtable uses google-cloud-core, even though it's a gRPC client. It appears to mostly (exclusively?) be for the type conversion helpers in https://github.com/googleapis/python-cloud-core/blob/master/google/cloud/_helpers.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment