Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add client_options to base client class #109

Merged
merged 2 commits into from Aug 18, 2020
Merged

feat: add client_options to base client class #109

merged 2 commits into from Aug 18, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards #69

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2020
@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
tseaver
tseaver suggested changes Aug 14, 2020
View reviewed changes
tests/unit/test_base_client.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@tseaver tseaver merged commit 65f7eda into googleapis:v2-staging Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HemangChothani @tseaver @yoshi-kokoro