Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docfx session to noxfile, normalize #100

Merged
merged 2 commits into from Aug 5, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 5, 2020

Unbreaking the docs-presubmit build.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 5, 2020

@tseaver Thanks, I think we should also run synthtool to have other changes, in order to see if the test is actually passing.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2020

@tmatsuo I lost my synthtool-fu during my hiatus. Can I just get my local copy updated to current master and run? Are there new OS-level dependencies?

@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 5, 2020

@tseaver Maybe I can add a commit to the branch.

For the record, I was told there is a dependency on bazel.

@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 5, 2020

I think you rebased, that should work too. Thanks!

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2020

@tmatsuo I merged #99 to master, and then merged it here, which seems to be getting docs-presubmit to actually run.

@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 5, 2020

The docs-presubmit is passing :)

Do you know why the samples are failing?

@tmatsuo
Copy link
Contributor

tmatsuo commented Aug 5, 2020

At a glance, the test has sth like time.sleep(10), so they might be eventually consistent tests.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2020

@tmatsuo We are hitting quota issues, breaking snippets / systests / samples.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fda22ae into master Aug 5, 2020
@tseaver tseaver deleted the chore-add-docfx-session branch August 5, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants