Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove local test_utils directory #89

Merged
merged 1 commit into from Apr 30, 2020
Merged

chore: remove local test_utils directory #89

merged 1 commit into from Apr 30, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 29, 2020

Closes #88. 馃

Test utils are now available in their own repo, meaning that we can remove the local copy of it.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label Apr 29, 2020
@plamut plamut requested a review from shollyman April 29, 2020 13:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
@plamut plamut requested review from HemangChothani and removed request for shollyman April 29, 2020 13:48
HemangChothani
HemangChothani approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@HemangChothani HemangChothani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
System tests failed which is not relevant to changes.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@plamut
Copy link
Contributor Author

plamut commented Apr 30, 2020 •
edited

I noticed that system test failure on another branch, too, but thought it has something to do with changes I was making to how BQ Storage client is used. I now see that it can also happen on master with a few unrelated modifications.

I cannot reproduce it locally, however, I only observed it on Kokoro. I restarted the checks, and if they fail again for the same reason, I will submit the workaround from another branch in a new PR.

Edit: The failure did not repeat, meaning that the test is flaky, but not a blocker. We can wait with the fix to be merged in #55.

@plamut plamut merged commit e2ddc2e into googleapis:master Apr 30, 2020
@plamut plamut deleted the iss-88 branch April 30, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HemangChothani HemangChothani HemangChothani approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove test_utils directory
4 participants
@plamut @HemangChothani @googlebot @yoshi-kokoro