feat: add support for INTERVAL data type to list_rows
#840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
tswast
added
the
do not merge
|
Some of these commits are from #829 |
jimfulton
reviewed
Jul 30, 2021
google/cloud/bigquery/_helpers.py
Outdated
| minutes = time_sign * int(parsed.group("minutes")) | ||
| seconds = time_sign * int(parsed.group("seconds")) | ||
| fraction = parsed.group("fraction") | ||
| microseconds = time_sign * int(fraction.ljust(6, "0")) if fraction else 0 |
There was a problem hiding this comment.
I can't tell from https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#interval_type if there are limits on any of these fields. 🤷
There was a problem hiding this comment.
I agree. The docs don't really explain much about how this data format actually works. From what is documented and trial and error, I think these are the limits:
Min
- years: -10000
- months: -11 (I think?)
- days: -3660000
- hours: -87840000
- minutes: -59 (I think?)
- seconds: -59 (I think?)
- microseconds: -999999 (I think?)
Max
- years: 10000
- months: 11 (I think?)
- days: 3660000
- hours: 87840000
- minutes: 59 (I think?)
- seconds: 59 (I think?)
- microseconds: 999999 (I think?)
I don't think we'll need any client-side validation for this, but it does remind me that we should have some unit tests that exercise these limits.
google/cloud/bigquery/enums.py
Outdated
Comment on lines
263
to
279
| BOOL = ScalarQueryParameterType("BOOL") | ||
| BOOLEAN = ScalarQueryParameterType("BOOL") | ||
| BIGDECIMAL = ScalarQueryParameterType("BIGNUMERIC") | ||
| BIGNUMERIC = ScalarQueryParameterType("BIGNUMERIC") | ||
| BYTES = ScalarQueryParameterType("BYTES") | ||
| INTEGER = ScalarQueryParameterType("INT64") | ||
| INT64 = ScalarQueryParameterType("INT64") | ||
| DATE = ScalarQueryParameterType("DATE") | ||
| DATETIME = ScalarQueryParameterType("DATETIME") | ||
| DECIMAL = ScalarQueryParameterType("NUMERIC") | ||
| FLOAT = ScalarQueryParameterType("FLOAT64") | ||
| FLOAT64 = ScalarQueryParameterType("FLOAT64") | ||
| NUMERIC = ScalarQueryParameterType("NUMERIC") | ||
| BIGNUMERIC = ScalarQueryParameterType("BIGNUMERIC") | ||
| DECIMAL = ScalarQueryParameterType("NUMERIC") | ||
| BIGDECIMAL = ScalarQueryParameterType("BIGNUMERIC") | ||
| BOOLEAN = ScalarQueryParameterType("BOOL") | ||
| BOOL = ScalarQueryParameterType("BOOL") | ||
| GEOGRAPHY = ScalarQueryParameterType("GEOGRAPHY") | ||
| TIMESTAMP = ScalarQueryParameterType("TIMESTAMP") | ||
| DATE = ScalarQueryParameterType("DATE") | ||
| INT64 = ScalarQueryParameterType("INT64") | ||
| INTEGER = ScalarQueryParameterType("INT64") | ||
| NUMERIC = ScalarQueryParameterType("NUMERIC") | ||
| STRING = ScalarQueryParameterType("STRING") | ||
| TIME = ScalarQueryParameterType("TIME") | ||
| DATETIME = ScalarQueryParameterType("DATETIME") | ||
| TIMESTAMP = ScalarQueryParameterType("TIMESTAMP") |
There was a problem hiding this comment.
Did you intend to include INTERVAL?
There was a problem hiding this comment.
I did but then reverted it because the query parameter support is incomplete. I could revert the alphabetization, but I figure we should do that at some point.
Merged
4 tasks
|
I think this is ready, but I'll keep the Do Not Merge label, as I think #829 should go in first. |
tswast
commented
Aug 11, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
@plamut Did you have any additional thoughts on this? It'd be good to get in before v3. I added some proposed unit tests with trailing |
plamut
reviewed
Oct 26, 2021
plamut
approved these changes
Oct 26, 2021
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
* test: refactor `list_rows` tests and add test for scalars * WIP: INTERVAL support * feat: add support for INTERVAL data type to `list_rows` * fix relativedelta construction for non-microseconds * WIP: support INTERVAL query params * remove dead code * INTERVAL not supported in query parameters * revert query parameter changes * add validation error for interval * add unit tests for extreme intervals * add dateutil to intersphinx * use dictionary for intersphinx * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add test case for trailing . * explicit none * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * truncate nanoseconds * use \d group for digits * use \d for consistency Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of most other features for
INTERVALis blocked by backend changes.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #826 🦕