Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a larger chunk size when loading data #799

Merged
merged 3 commits into from Jul 22, 2021
Merged

fix: use a larger chunk size when loading data #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff67de
The chunk size used for data uploads was too small (1MB). Now it's 10…
jimfulton Jul 22, 2021
bcfe7d6
fix: The chunk size used for data uploads was too small
jimfulton Jul 22, 2021
482d4d9
Merge branch 'riversnake-fix-chunk-size' of github.com:googleapis/pyt…
jimfulton Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigquery/client.py
View file
Open in desktop
Expand Up @@ -98,7 +98,7 @@
from google.cloud.bigquery.table import RowIterator


_DEFAULT_CHUNKSIZE = 1048576 # 1024 * 1024 B = 1 MB
_DEFAULT_CHUNKSIZE = 100 * 1024 * 1024 # 100 MB
_MAX_MULTIPART_SIZE = 5 * 1024 * 1024
_DEFAULT_NUM_RETRIES = 6
_BASE_UPLOAD_TEMPLATE = "{host}/upload/bigquery/v2/projects/{project}/jobs?uploadType="
Expand Down
20 changes: 20 additions & 0 deletions tests/unit/test_client.py
View file
Open in desktop
Expand Up @@ -8076,3 +8076,23 @@ def test_schema_to_json_with_file_object(self):

client.schema_to_json(schema_list, fake_file)
assert file_content == json.loads(fake_file.getvalue())


def test_upload_chunksize(client):
with mock.patch("google.cloud.bigquery.client.ResumableUpload") as RU:
upload = RU.return_value

upload.finished = False

def transmit_next_chunk(transport):
upload.finished = True
result = mock.MagicMock()
result.json.return_value = {}
return result

upload.transmit_next_chunk = transmit_next_chunk
f = io.BytesIO()
client.load_table_from_file(f, "foo.bar")

chunk_size = RU.call_args_list[0][0][1]
assert chunk_size == 100 * (1 << 20)