Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use pandas function to check for NaN #750

Merged
merged 4 commits into from Jul 12, 2021
Merged

fix: use pandas function to check for NaN #750

merged 4 commits into from Jul 12, 2021

Commits on Jul 11, 2021

  1. fix: use pandas function to check for NaN 

    Starting with pandas 1.0, an experimental pandas.NA value (singleton) is available to represent scalar missing values as
opposed to numpy.nan. Comparing the variable with itself results in a pandas.NA value that doesn't support type-casting
to boolean. Using the build-in pandas.isna function handles all pandas supported NaN values.
    @LinuxChristian
    LinuxChristian committed Jul 11, 2021
    Copy the full SHA
    ebdc683 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. tests: Skip tests if pandas below required version

    @LinuxChristian
    LinuxChristian committed Jul 12, 2021
    Copy the full SHA
    f86d103 View commit details
    Browse the repository at this point in the history

  2. tests: compare expected and actual directly as lists

    @LinuxChristian
    LinuxChristian committed Jul 12, 2021
    Copy the full SHA
    659e9f7 View commit details
    Browse the repository at this point in the history

  3. Fix pytest.mark.skipif spelling

    @plamut
    plamut committed Jul 12, 2021
    Copy the full SHA
    dc0529b View commit details
    Browse the repository at this point in the history