Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detect obsolete BQ Storage extra at runtime #666

Merged
merged 8 commits into from May 20, 2021
Merged

feat: detect obsolete BQ Storage extra at runtime #666

merged 8 commits into from May 20, 2021

Commits on May 17, 2021

  1. feat: detect obsolete BQ Storage extra at runtime

    @plamut
    plamut committed May 17, 2021
    Copy the full SHA
    8e772e4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Cover the changes with unit tests

    @plamut
    plamut committed May 18, 2021
    Copy the full SHA
    af8ddec View commit details
    Browse the repository at this point in the history

  2. Skip BQ Storage version tests if extra missing

    @plamut
    plamut committed May 18, 2021
    Copy the full SHA
    24aea73 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Rename and improve _create_bqstorage_client() 

    The method is renamed to _ensure_bqstorage_client() and now performs
a check if BQ Storage dependency is recent enough.
    @plamut
    plamut committed May 19, 2021
    Copy the full SHA
    cbb814c View commit details
    Browse the repository at this point in the history

  2. Remove BQ Storage check from dbapi.Cursor 

    The check is now performed in dbapi.Connection, which is sufficient.
    @plamut
    plamut committed May 19, 2021
    Copy the full SHA
    89c0e1e View commit details
    Browse the repository at this point in the history

  3. Remove BQ Storage check in _pandas_helpers 

    The methods in higher layers already do the same check before
a BQ Storage client instance is passed to
_pandas_helpers._download_table_bqstorage() helper.
    @plamut
    plamut committed May 19, 2021
    Copy the full SHA
    4e5b31a View commit details
    Browse the repository at this point in the history

  4. Simplify BQ Storage client factory in magics 

    Lean more heavily on client._ensure_bqstorage_client() to de-duplicate
logic.
    @plamut
    plamut committed May 19, 2021
    Copy the full SHA
    fb3335a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Cover missing code lines with tests

    @plamut
    plamut committed May 20, 2021
    Copy the full SHA
    5d01bdb View commit details
    Browse the repository at this point in the history