Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept DatasetListItem where DatasetReference is accepted #597

Merged
merged 20 commits into from Apr 12, 2021
Merged

feat: accept DatasetListItem where DatasetReference is accepted #597

merged 20 commits into from Apr 12, 2021

Commits on Apr 7, 2021

  1. split out and pytestify list_tables tests. 

    Also, exercise dataset polymorphism in some of the tests.
    @jimfulton
    jimfulton committed Apr 7, 2021
    Copy the full SHA
    260672c View commit details
    Browse the repository at this point in the history

  2. list_tables now accepts DatasetListItem objects

    @jimfulton
    jimfulton committed Apr 7, 2021
    Copy the full SHA
    3a122d7 View commit details
    Browse the repository at this point in the history

  3. Get coverage to 100% 

    But why do we run coverage on test code?
    @jimfulton
    jimfulton committed Apr 7, 2021
    Copy the full SHA
    d453031 View commit details
    Browse the repository at this point in the history

  4. lint

    @jimfulton
    jimfulton committed Apr 7, 2021
    Copy the full SHA
    61b53bc View commit details
    Browse the repository at this point in the history

  5. Update exception text for DatasetListItem

    @jimfulton
    jimfulton committed Apr 7, 2021
    Copy the full SHA
    0b1b7c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Bypass opentelemetry tracing in unit tests.

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    1349d4b View commit details
    Browse the repository at this point in the history

  2. Got rid of opentelemetry tracing checks. They aren't needed.

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    a93d6dc View commit details
    Browse the repository at this point in the history

  3. abstracted dataset-argument handling 

    And applied it to `list_tables` and `list_models`.
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    b4ea2a8 View commit details
    Browse the repository at this point in the history

  4. Converted list_model tests to pytest and included check for dataset p… 

    …olymorphism
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    7128789 View commit details
    Browse the repository at this point in the history

  5. removed unneeded blanl lines.

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    0ee721b View commit details
    Browse the repository at this point in the history

  6. Made list_routines accept DatasetListItem 

    and conveted list_routines tests to pytest.
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    c778e9b View commit details
    Browse the repository at this point in the history

  7. create_dataset accepts DatasetListItem 

    Also converted create_dataset tests to pytest.

(And fixed some long lines.)
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    4fb971b View commit details
    Browse the repository at this point in the history

  8. Converted list_routine tests to pytest

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    4154204 View commit details
    Browse the repository at this point in the history

  9. include string dataset representation in dataset polymorphism.

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    be90063 View commit details
    Browse the repository at this point in the history

  10. removed some unused imports

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    bbe1fd2 View commit details
    Browse the repository at this point in the history

  11. Updated delete_dataset tests 

    - Polymorphoc on dataset
- pytest
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    2aa4954 View commit details
    Browse the repository at this point in the history

  12. black

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    fd39b8b View commit details
    Browse the repository at this point in the history

  13. lint

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    05d89f8 View commit details
    Browse the repository at this point in the history

  14. We don't actually need to avoid opentelemetry 

    And a 3.6 test dependened on it.
    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    440ac82 View commit details
    Browse the repository at this point in the history

  15. fixed docstrings to include DatasetListItem in dataset polymorphic APIs.

    @jimfulton
    jimfulton committed Apr 8, 2021
    Copy the full SHA
    d4d329e View commit details
    Browse the repository at this point in the history