fix: avoid overly strict dependency on pyarrow 3.x #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excludes bignumeric_type from all extra
tswast
requested review from
a team and
shollyman
and removed request for
a team
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
|
I suspect that the reason it wasn't failing on Kokoro but it was for me is that our Kokoro setup has an older version of pip that didn't have as strict of dependency resolver. |
plamut
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
I suppose the assumption is that users who want BIGNUMERIC support will not use "all", but by explicitly specifying the "bignumeric_type" extra?
The change can be breaking for users that decided to use the fairly recently added BIGNUMERIC support through the "all" extra, but that's probably less bad than everyone else on Python3.6 Mac already using the "all" extra, but are now suddenly facing a regression due to a feature they did not voluntarily request.
shollyman
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes bignumeric_type from all extra
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #563 馃