Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ExternalConfig.connection_id property to connect to external sources #560

Merged
merged 4 commits into from Mar 22, 2021
Merged

feat: add ExternalConfig.connection_id property to connect to external sources #560

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd07824
feat: add `ExternalConfig.connection_id` property to connect to exter…
tswast Mar 18, 2021
915462d
add tests
tswast Mar 19, 2021
0260b03
Merge remote-tracking branch 'upstream/master' into issue182112589-co…
tswast Mar 19, 2021
c922eb9
fix unit tests
tswast Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions google/cloud/bigquery/external_config.py
View file
Open in desktop
Expand Up @@ -760,6 +760,14 @@ def schema(self):
prop = self._properties.get("schema", {})
return [SchemaField.from_api_repr(field) for field in prop.get("fields", [])]

@property
def connection_id(self):
tswast marked this conversation as resolved.
Show resolved Hide resolved
return self._properties.get("connectionId")

@connection_id.setter
def connectionid(self, value):
self._properties["connectionId"] = value

@schema.setter
def schema(self, value):
prop = value
Expand Down