Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom cell magic parser #213

Merged
merged 20 commits into from Sep 9, 2020
Merged

feat: add custom cell magic parser #213

merged 20 commits into from Sep 9, 2020

Commits on Aug 28, 2020

  1. chore: Move cell magic code into its own directory

    @plamut
    plamut committed Aug 28, 2020
    Copy the full SHA
    c5e63c6 View commit details
    Browse the repository at this point in the history

  2. Add custom argument parser for cell magic

    @plamut
    plamut committed Aug 28, 2020
    Copy the full SHA
    199974f View commit details
    Browse the repository at this point in the history

  3. Add AST node visitor

    @plamut
    plamut committed Aug 28, 2020
    Copy the full SHA
    d3525d4 View commit details
    Browse the repository at this point in the history

  4. Use a custom parser for cell magic arguments

    @plamut
    plamut committed Aug 28, 2020
    Copy the full SHA
    5690b81 View commit details
    Browse the repository at this point in the history

  5. Improve cell magic parser test coverage

    @plamut
    plamut committed Aug 28, 2020
    Copy the full SHA
    976567c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Generalize valid option values 

    The parser should accept as wide a range of values as possible and let
the code that delas with the semantics to decide whether the values are
good or not.
    @plamut
    plamut committed Sep 2, 2020
    Copy the full SHA
    f57c6cd View commit details
    Browse the repository at this point in the history

  2. Fix recognizing --params option in state 3 

    The --params option spec must be followed by a non-alphanumeric
character, otherwise it's a different option spec (e.g. --paramsX).
    @plamut
    plamut committed Sep 2, 2020
    Copy the full SHA
    c7e4420 View commit details
    Browse the repository at this point in the history

  3. Fix typo in comment

    @plamut
    plamut committed Sep 2, 2020
    Copy the full SHA
    90c504e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-cellmagic-parser

    @plamut
    plamut committed Sep 2, 2020
    Copy the full SHA
    3b94a55 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Cover missing parser code path with a test

    @plamut
    plamut committed Sep 3, 2020
    Copy the full SHA
    5249c6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-cellmagic-parser

    @plamut
    plamut committed Sep 3, 2020
    Copy the full SHA
    83218a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Preserve the cell magic context's import path 

    The context still needs to be importable from the old path
    @plamut
    plamut committed Sep 4, 2020
    Copy the full SHA
    2c74ec8 View commit details
    Browse the repository at this point in the history

  2. Clarify lexer states

    @plamut
    plamut committed Sep 4, 2020
    Copy the full SHA
    19af056 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Replace re.scanner with finditer()

    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    4cbf7f2 View commit details
    Browse the repository at this point in the history

  2. Fix typo in docstring

    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    64f19b5 View commit details
    Browse the repository at this point in the history

  3. Simplify string literal in a single line 

    Apparently black just places all implicitly concatenated string
literals in a single line when short enough without replacing them
with a single string literal.
    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    5d10d36 View commit details
    Browse the repository at this point in the history

  4. Explain the visitors module.

    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    46d1def View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-cellmagic-parser

    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    ed01a66 View commit details
    Browse the repository at this point in the history

  6. Pass pos as a positional arg to finditer() 

    This is necessary to retain Python 2 compatibility.
    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    d9dd3e0 View commit details
    Browse the repository at this point in the history

  7. Resolve coverage complaint about a code path 

    The tokens are designed in a way that the scanner *always* returns
some match, even if just UNKNOWN or EOL. The "no matches" code path
can thus never be taken, but the coverage check can't know that.
    @plamut
    plamut committed Sep 9, 2020
    Copy the full SHA
    415c608 View commit details
    Browse the repository at this point in the history