Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid "Unable to determine type" warning with JSON columns in to_dataframe #1876

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 27, 2024

TODO:

  • tests
  • maybe we don't want string columns for JSON?

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 27, 2024
@tswast
Copy link
Contributor Author

tswast commented Mar 27, 2024

I might actually want to do something in db-dtypes so that even though it's a string the unboxed version would give a parsed object like the behavior is when the REST API is used.

@tswast
Copy link
Contributor Author

tswast commented Mar 27, 2024

Right now the behavior is inconsistent across REST and BQ Storage API.

@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2024
@tswast
Copy link
Contributor Author

tswast commented Mar 28, 2024

Marking as do not merge for now, as this makes JSON dtype consistent now but always return string dtype like the BQ Storage Read API code path does, which isn't ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant