Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning #162

Merged
merged 4 commits into from Jul 13, 2020
Merged

feat(bigquery): add __eq__ method for class PartitionRange and RangePartitioning #162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
008ef28
feat(bigquery): add __eq__ method for class PartitionRange and RangeP…
HemangChothani Jul 10, 2020
2ce60f2
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani Jul 10, 2020
6b332c0
feat(bigquery): change class object to unhashable
HemangChothani Jul 13, 2020
aa7d5e9
feat(bigquery): change the assertion
HemangChothani Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions google/cloud/bigquery/table.py
View file
Open in desktop
Expand Up @@ -1903,8 +1903,7 @@ def __repr__(self):
key_vals = ["{}={}".format(key, val) for key, val in self._key()]
return "PartitionRange({})".format(", ".join(key_vals))

def __hash__(self):
return hash(self._key())
__hash__ = None


class RangePartitioning(object):
Expand Down Expand Up @@ -1984,8 +1983,7 @@ def __repr__(self):
key_vals = ["{}={}".format(key, repr(val)) for key, val in self._key()]
return "RangePartitioning({})".format(", ".join(key_vals))

def __hash__(self):
return hash(self._key())
__hash__ = None


class TimePartitioningType(object):
Expand Down
35 changes: 4 additions & 31 deletions tests/unit/test_table.py
View file
Open in desktop
Expand Up @@ -3550,19 +3550,10 @@ def test__eq___type_mismatch(self):
self.assertNotEqual(object_under_test, object())
self.assertEqual(object_under_test, mock.ANY)

def test___hash__set_equality(self):
def test_unhashable_object(self):
object_under_test1 = self._make_one(start=1, end=10, interval=2)
object_under_test2 = self._make_one(start=1, end=10, interval=3)
set_one = {object_under_test1, object_under_test2}
set_two = {object_under_test1, object_under_test2}
self.assertEqual(set_one, set_two)

def test___hash__not_equals(self):
object_under_test1 = self._make_one(start=1, end=10, interval=2)
object_under_test2 = self._make_one(start=1, end=10, interval=3)
set_one = {object_under_test1}
set_two = {object_under_test2}
self.assertNotEqual(set_one, set_two)
self.assertIsNone(object_under_test1.__hash__)
plamut marked this conversation as resolved.
Show resolved Hide resolved

def test_repr(self):
object_under_test = self._make_one(start=1, end=10, interval=2)
Expand Down Expand Up @@ -3655,31 +3646,13 @@ def test__eq___type_mismatch(self):
self.assertNotEqual(object_under_test, object())
self.assertEqual(object_under_test, mock.ANY)

def test___hash__set_equality(self):
def test_unhashable_object(self):
from google.cloud.bigquery.table import PartitionRange

object_under_test1 = self._make_one(
range_=PartitionRange(start=1, end=10, interval=2), field="integer_col"
)
object_under_test2 = self._make_one(
range_=PartitionRange(start=1, end=10, interval=2), field="float_col"
)
set_one = {object_under_test1, object_under_test2}
set_two = {object_under_test1, object_under_test2}
self.assertEqual(set_one, set_two)

def test___hash__not_equals(self):
from google.cloud.bigquery.table import PartitionRange

object_under_test1 = self._make_one(
range_=PartitionRange(start=1, end=10, interval=2), field="integer_col"
)
object_under_test2 = self._make_one(
range_=PartitionRange(start=1, end=10, interval=2), field="float_col"
)
set_one = {object_under_test1}
set_two = {object_under_test2}
self.assertNotEqual(set_one, set_two)
self.assertIsNone(object_under_test1.__hash__)

def test_repr(self):
from google.cloud.bigquery.table import PartitionRange
Expand Down