doc: update wording in rowiterator docstrings to reduce confusion #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal: Talking about partition filtration can be problematic, so refer to Storage API capabilities more obliquely. Particularly, partition filtration is possible via a query or a direct storage API read, so don't use as severe of language when describing helper mechanisms such as to_dataframe() on row iterators. Fixes: googleapis/python-bigquery-storage#22
googlebot
added
the
cla: yes
|
I anticipate this may cause minor conflicts with #55 so let's get that in, then we can followup with smaller doc changes like this and cleanup for the small anonymous result issues (I didn't excise those adjacent language blocks). |
plamut
added
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talking about partition filtration can be problematic, so refer
to Storage API capabilities more obliquely. Particularly, partition
filtration is possible via a query or a direct storage API read, so
don't use as severe of language when describing helper mechanisms such
as to_dataframe() on row iterators.
Fixes: googleapis/python-bigquery-storage#22