Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load table from json #1248
fix: load table from json #1248
Changes from 12 commits
46c54eb
c237d2b
1975087
1d06dcd
74efb3a
92915d7
04654c0
aa1eba7
7a6b5c4
f21b6cf
d6cf378
8f4d034
8d735e0
6afe300
66d4581
9a5d71f
dc9838d
1d64518
d883af3
0535084
68511b2
b3faa95
3ca4dc8
e1f9187
1c3d6a8
287a282
0fb771e
efdd87b
51e79b8
04c9fc8
6f8bcc1
ebe3348
57b371a
28f728e
e83d3bf
0d075b3
81d5345
2dc5795
5c3e2b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add an assert checking that the row values were correctly inserted as strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to provide schema here?