fix: skip geography_as_object conversion for REPEATED fields #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
|
@tswast whaddya think? 🙂 |
tswast
approved these changes
Apr 20, 2022
tswast
added
the
kokoro:force-run
tswast
added
the
automerge
tswast
changed the title
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
waltaskew
pushed a commit
to waltaskew/python-bigquery
that referenced
this pull request
Jul 20, 2022
…pis#1220) Co-authored-by: Tim Swast <swast@google.com>
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…pis#1220) Co-authored-by: Tim Swast <swast@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213 🦕
I looked into adding a test for this specific case but the existing test data helpers don't seem to support REPEATED fields from what I could tell, sooooo I gave up...