Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TimePartitioning repr evaluable #110

Merged
merged 14 commits into from Oct 13, 2020
Merged
15 changes: 14 additions & 1 deletion google/cloud/bigquery/table.py
Expand Up @@ -2128,7 +2128,20 @@ def to_api_repr(self):
return self._properties

def _key(self):
return tuple(sorted(self._properties.items()))
# because we are only "renaming" top level keys shallow copy is sufficient here.
properties = self._properties.copy()
francois-baptiste marked this conversation as resolved.
Show resolved Hide resolved
# calling repr for non built-in type objects.
properties["type_"] = repr(properties.pop("type"))
if "field" in properties:
# calling repr for non built-in type objects.
properties["field"] = repr(properties["field"])
if "requirePartitionFilter" in properties:
properties["require_partition_filter"] = properties.pop(
"requirePartitionFilter"
)
if "expirationMs" in properties:
properties["expiration_ms"] = properties.pop("expirationMs")
return tuple(sorted(properties.items()))

def __eq__(self, other):
if not isinstance(other, TimePartitioning):
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_table.py
Expand Up @@ -3743,7 +3743,7 @@ def test___hash__not_equals(self):

def test___repr___minimal(self):
time_partitioning = self._make_one()
expected = "TimePartitioning(type=DAY)"
expected = "TimePartitioning(type_='DAY')"
self.assertEqual(repr(time_partitioning), expected)

def test___repr___explicit(self):
Expand All @@ -3752,7 +3752,7 @@ def test___repr___explicit(self):
time_partitioning = self._make_one(
type_=TimePartitioningType.DAY, field="name", expiration_ms=10000
)
expected = "TimePartitioning(" "expirationMs=10000," "field=name," "type=DAY)"
expected = "TimePartitioning(expiration_ms=10000,field='name',type_='DAY')"
self.assertEqual(repr(time_partitioning), expected)

def test_set_expiration_w_none(self):
Expand Down