Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for query sessions #1029

Closed
wants to merge 7 commits into from
Closed

feat: add support for query sessions #1029

wants to merge 7 commits into from

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Oct 23, 2021

Closes #1026.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from tswast, shollyman and a team October 23, 2021 08:29
@plamut plamut requested a review from a team as a code owner October 23, 2021 08:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 23, 2021
plamut
plamut commented Oct 23, 2021
View reviewed changes
google/cloud/bigquery/job/query.py
"""The session ID the query was part of, if any.

See:
https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobStatistics2.FIELDS.session_info
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Session info currently does not exist in the docs, thus this (predicted) anchor on the page currently doesn't have any effect.

@tswast
Copy link
Contributor

tswast commented Oct 25, 2021

I haven't taken a close look at this yet. Does it build on #1024 ?

@plamut
Copy link
Contributor Author

plamut commented Oct 25, 2021

I haven't taken a close look at this yet. Does it build on #1024 ?

Oh... is that a duplicate? 😕

No, haven't checked with that, I can do it tomorrow... but merge conflicts seem likely.

@tswast tswast mentioned this pull request Oct 25, 2021
Merged
4 tasks
@plamut plamut closed this in #1024 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast Awaiting requested review from tswast

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add session support
2 participants
@plamut @tswast