Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ConnectionError to default retry #571

Merged
merged 1 commit into from Mar 23, 2021
Merged

fix: add ConnectionError to default retry #571

merged 1 commit into from Mar 23, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #434 馃

@tswast tswast requested review from a team and shollyman and removed request for a team March 23, 2021 17:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 23, 2021
@tswast tswast merged commit a3edb8b into googleapis:master Mar 23, 2021
@tswast tswast deleted the issue434-connection-error-retries branch March 23, 2021 20:06
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 23, 2021
@release-please
chore: release 2.13.1 (#572)
e175d3a 
馃 I have created a release \*beep\* \*boop\*
---
### [2.13.1](https://www.github.com/googleapis/python-bigquery/compare/v2.13.0...v2.13.1) (2021-03-23)


### Bug Fixes

* add ConnectionError to default retry ([#571](https://www.github.com/googleapis/python-bigquery/issues/571)) ([a3edb8b](https://www.github.com/googleapis/python-bigquery/commit/a3edb8b921e029e2c03d33302d408ad5d4e9d4ad))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@tswast tswast mentioned this pull request Apr 21, 2021
Closed
@cojenco cojenco mentioned this pull request May 17, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-storage that referenced this pull request May 20, 2021
@cojenco
fix: add ConnectionError to default retry (#445)
8344253 
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes #426 馃
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
fix: add ConnectionError to default retry (googleapis#445)
f072f3d 
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes googleapis#426 馃
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
fix: add ConnectionError to default retry (googleapis#445)
daac538 
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes googleapis#426 馃
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConnectionError in Client.insert_rows_json()
2 participants
@tswast @shollyman