Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): add create_table_clustered code snippet #291

Merged
merged 5 commits into from Oct 6, 2020
Merged

docs(samples): add create_table_clustered code snippet #291

merged 5 commits into from Oct 6, 2020

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Oct 2, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #290 🦕

@ryanyuan ryanyuan requested a review from a team October 2, 2020 12:05
@ryanyuan ryanyuan requested a review from a team as a code owner October 2, 2020 12:05
@ryanyuan ryanyuan requested a review from engelke October 2, 2020 12:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
tswast
tswast reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you also add a test file to the samples directory?

@ryanyuan
Copy link
Contributor Author

ryanyuan commented Oct 3, 2020

Thanks for the contribution! Could you also add a test file to the samples directory?

Done.

PTAL. Cheers! @tswast

@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
engelke
engelke approved these changes Oct 6, 2020
View reviewed changes
Copy link

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit d1eb8b3 into googleapis:master Oct 6, 2020
@tswast
Copy link
Contributor

tswast commented Oct 6, 2020

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

@ryanyuan
Copy link
Contributor Author

ryanyuan commented Oct 6, 2020

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

Awesome! Thank you @tswast

gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 8, 2020
@release-please
chore: release 2.1.0 (#301)
1a4dc12 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.1.0](https://www.github.com/googleapis/python-bigquery/compare/v2.0.0...v2.1.0) (2020-10-08)


### Features

* add constants for MONTH and YEAR time partitioning types ([#283](https://www.github.com/googleapis/python-bigquery/issues/283)) ([9090e1c](https://www.github.com/googleapis/python-bigquery/commit/9090e1ccd8825a97835325b4829f6e7ecfd9ea88))


### Bug Fixes

* remove unnecessary dependency on libcst ([#308](https://www.github.com/googleapis/python-bigquery/issues/308)) ([c055930](https://www.github.com/googleapis/python-bigquery/commit/c05593094c1405f752b2c51b15202a6dbb5cb83f))


### Performance Improvements

* remove redundant array deepcopy ([#26](https://www.github.com/googleapis/python-bigquery/issues/26)) ([b54f867](https://www.github.com/googleapis/python-bigquery/commit/b54f86769c982ce5c8fcbf3889f82450428bb40c))


### Documentation

* **samples:** add create_table_clustered code snippet ([#291](https://www.github.com/googleapis/python-bigquery/issues/291)) ([d1eb8b3](https://www.github.com/googleapis/python-bigquery/commit/d1eb8b3dcc789916c5d3ba8464f62b1f8bef35ff))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add create_table_clustered sample code
4 participants
@ryanyuan @tswast @engelke @yoshi-kokoro