Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read_session optional to ReadRowsStream.rows() #228

Merged
merged 5 commits into from Jul 9, 2021
Merged

feat: read_session optional to ReadRowsStream.rows() #228

merged 5 commits into from Jul 9, 2021

Commits on Jul 8, 2021

  1. feat: read_session optional to ReadRowsStream.rows() 

    The schema from the first `ReadRowsResponse` message can be used to decode
messages, instead.

Note: `to_arrow()` and `to_dataframe()` do not work on an empty stream unless a
`read_session` has been passed in, as the schema is not available. This should
not affect `google-cloud-bigquery` and `pandas-gbq`, as those packages use the
lower-level message->dataframe/arrow methods.
    @tswast
    tswast committed Jul 8, 2021
    Copy the full SHA
    378db09 View commit details
    Browse the repository at this point in the history

  2. revert change to comment

    @tswast
    tswast committed Jul 8, 2021
    Copy the full SHA
    ffc5df2 View commit details
    Browse the repository at this point in the history

  3. use else for empty arrow streams in try-except block 

    Co-authored-by: Tres Seaver <tseaver@palladion.com>
    @tswast @tseaver
    tswast and tseaver committed Jul 8, 2021
    Copy the full SHA
    0d693b3 View commit details
    Browse the repository at this point in the history

  4. update docstring to reflect that readsession and readrowsresponse can… 

    … be used interchangeably
    @tswast
    tswast committed Jul 8, 2021
    Copy the full SHA
    dcb868b View commit details
    Browse the repository at this point in the history

  5. update arrow deserializer, too

    @tswast
    tswast committed Jul 8, 2021
    Copy the full SHA
    2237694 View commit details
    Browse the repository at this point in the history