Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove manual workaround for response size validation #112

Merged
merged 2 commits into from Jan 12, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 11, 2021

Now that the main template has the fix for #78, the hack in synth.py is no longer needed. I manually run synthtool to catch up from all changes since December 12 when #105 was opened.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #105 馃

@tswast tswast requested a review from a team January 11, 2021 20:58
@tswast tswast requested a review from a team as a code owner January 11, 2021 20:58
@tswast tswast requested review from steffnay and dinagraves and removed request for a team January 11, 2021 20:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jan 11, 2021
@@ -97,44 +97,6 @@
'\g<0>\n\n session.install("google-cloud-bigquery")',
)

# Remove client-side validation of message length.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is the only manual change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for python-bigquery-storage
2 participants