Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_arrow, ReadRowsIterable.to_dataframe, ReadRowsStream.to_arrow #247

Closed
wants to merge 3 commits into from
Closed

docs: deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_arrow, ReadRowsIterable.to_dataframe, ReadRowsStream.to_arrow #247

wants to merge 3 commits into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 23, 2021 •
edited

If downloading a whole result set, use the google-cloud-bigquery package, instead.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #230 🦕

@tswast
docs: deprecate ReadRowsStream.to_dataframe, `ReadRowsIterable.to_a…
7bd4654 
…rrow`, `ReadRowsIterable.to_dataframe`, `ReadRowsStream.to_arrow`

If downloading a whole result set, use the `google-cloud-bigquery` package, instead.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jul 23, 2021
@tswast tswast changed the title docs: deprecate ReadRowsStream.to_dataframe, `ReadRowsIterable.to_a… docs: deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_arrow, ReadRowsIterable.to_dataframe, ReadRowsStream.to_arrow Jul 23, 2021
@plamut plamut changed the base branch from master to main August 25, 2021 10:09
@plamut plamut deleted the branch googleapis:main August 26, 2021 11:29
@plamut plamut closed this Aug 26, 2021
@plamut
Copy link
Contributor

plamut commented Aug 26, 2021

This PR was accidentally closed when main was deleted, and now I cannot re-open it even if I temporarily re-create main. Please open it again against master, thanks!

@meredithslota meredithslota mentioned this pull request Jun 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_dataframe
2 participants
@tswast @plamut