Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_dataframe #230

Open
tswast opened this issue Jul 8, 2021 · 3 comments
Open
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Jul 8, 2021

These higher-level functions seemed useful at the time of implementation, but they were not needed by google-cloud-bigquery, pandas-gbq, or even experimental Dask (dask/dask#3121 (comment)). Instead, only the lower-level ReadRowsPage.to_arrow and ReadRowsPage.to_dataframe methods were used.

Deprecating these can allow us to deprecate the passing around of read_session fully because we won't have to worry about returning something sensible for empty streams.

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jul 8, 2021
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Jul 8, 2021
@tswast
Copy link
Contributor Author

tswast commented Sep 21, 2021

@tswast tswast changed the title deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_arrow, ReadRowsIterable.to_dataframe, ReadRowsStream.to_arrow deprecate ReadRowsStream.to_dataframe, ReadRowsIterable.to_dataframe Sep 21, 2021
@tswast tswast removed their assignment Mar 28, 2023
@meredithslota
Copy link

#247 has a comment about the PR being accidentally closed; I believe we can reuse those changes.

@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. next major: breaking change this is a change that we should wait to bundle into the next major version and removed type: process A process-related concern. May include testing, release, or the like. labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants