Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Register Alembic dialect. Fix README #70

Closed

Conversation

mvoitko
Copy link
Contributor

@mvoitko mvoitko commented Oct 1, 2020

I started adding Alembic support as mentioned here, but I need help to define table altering instructions in BigQuery.

@mvoitko mvoitko mentioned this pull request Oct 1, 2020
@mvoitko mvoitko force-pushed the feature/register-dialect-in-alembic branch from 0a8f5b5 to 7833350 Compare October 1, 2020 12:55
@mvoitko mvoitko force-pushed the feature/register-dialect-in-alembic branch from 7833350 to caab18b Compare October 1, 2020 13:01
@tswast
Copy link
Collaborator

tswast commented Jan 7, 2021

Just weeks after you sent this PR, some limited ALTER TABLE support was added. :-) https://cloud.google.com/bigquery/docs/release-notes?hl=en#October_14_2020

@pedro-iatzky
Copy link

Can we have this feature merged?
I think it is very powerful even if we can only execute SQL statements with the op.execute() method?

@jimfulton
Copy link
Contributor

Closing in favor of #183.

Some notes:

  • I would have started from this PR, but there were so many changes in the underlying code, it was easier to start over.
  • The registration code was pretty much all that was needed.
  • This package shouldn't depend on alembic, but leverage it if it's available.
  • feat: Alembic support #183 includes documentation and a system test showing what works, which is quite a lot.

@jimfulton jimfulton closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants